remove punycode, fix up index.js lookup

Author: cmalonzo

build-tests/api-extractor-test-05/dist/tsdoc-metadata.json

@@ -5,7 +5,7 @@
   "toolPackages": [
     {
       "packageName": "@microsoft/api-extractor",
-      "packageVersion": "7.58.1"
+      "packageVersion": "7.58.2"
     }
   ]
 }

common/config/subspaces/build-tests-subspace/pnpm-lock.yaml

@@ -1,6 +1,6 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "17c0403e10c0036d1cc57226f0d3c405f0e063b6",
+  "pnpmShrinkwrapHash": "22153a6cd81b35a26ccaa94430114d26ad48026f",
   "preferredVersionsHash": "550b4cee0bef4e97db6c6aad726df5149d20e7d9",
-  "packageJsonInjectedDependenciesHash": "aee23fb9482ddf1d02726d7cb55c36bc4cc5d4bf"
+  "packageJsonInjectedDependenciesHash": "1fa5e72901cbee765da0520b9b3800b96efd87c8"
 }

common/config/subspaces/build-tests-subspace/repo-state.json

@@ -38,8 +38,7 @@
     "jest-config": "~30.3.0",
     "jest-resolve": "~30.3.0",
     "jest-snapshot": "~30.3.0",
-    "lodash": "~4.18.1",
-    "punycode": "~2.3.1"
+    "lodash": "~4.18.1"
   },
   "devDependencies": {
     "@jest/types": "30.3.0",

common/config/subspaces/default/pnpm-lock.yaml

@@ -89,17 +89,13 @@ function applyPatch(): void {
     }
     // Load the module
     const targetModule: IBaseWorkerPoolModule = require(targetPath);
-    // Obtain the metadata for the module
-    let targetModuleMetadata: NodeModule | undefined = undefined;
-    for (const childModule of module.children) {
-      // Match by full path to avoid false positives (e.g. many modules named index.js)
-      if (childModule.filename === targetPath) {
-        if (targetModuleMetadata) {
-          throw new Error('More than one child module matched while detecting Node.js module metadata');
-        }
-        targetModuleMetadata = childModule;
-      }
-    }
+    // Obtain the metadata for the module from require.cache.
+    // We can't use module.children because if the module was already in the cache before this
+    // require() call (loaded transitively by something else), Node.js returns the cached result
+    // without appending it to module.children.
+    // require.resolve() gives us the exact key Node.js uses in require.cache.
+    const resolvedTargetPath: string = require.resolve(targetPath);
+    const targetModuleMetadata: NodeModule | undefined = require.cache[resolvedTargetPath];
     if (!targetModuleMetadata) {
       throw new Error(`Failed to detect the Node.js module metadata for ${path.basename(targetPath)}`);
     }