Skip to content

Commit a5928b8

Browse files
committed
fix: resolve comments
1 parent 246167e commit a5928b8

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

libraries/rush-lib/src/api/test/__snapshots__/RushCommandLine.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1157,7 +1157,7 @@ Object {
11571157
"shortName": undefined,
11581158
},
11591159
Object {
1160-
"description": "The name of the subspace to use for the bridge package.",
1160+
"description": "The name of the subspace to use for the hotlinked package.",
11611161
"environmentVariable": undefined,
11621162
"kind": "StringList",
11631163
"longName": "--subspace",

libraries/rush-lib/src/cli/actions/BridgePackageAction.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
22
// See LICENSE in the project root for license information.
33

4-
import type { CommandLineStringListParameter, CommandLineStringParameter } from '@rushstack/ts-command-line';
4+
import type {
5+
CommandLineStringListParameter,
6+
IRequiredCommandLineStringParameter
7+
} from '@rushstack/ts-command-line';
58

69
import type { RushCommandLineParser } from '../RushCommandLineParser';
710
import { BaseHotlinkPackageAction } from './BaseHotlinkPackageAction';
@@ -13,7 +16,7 @@ import { Async } from '@rushstack/node-core-library';
1316
import type { RushConfigurationProject } from '../../api/RushConfigurationProject';
1417

1518
export class BridgePackageAction extends BaseHotlinkPackageAction {
16-
private readonly _versionParameter: CommandLineStringParameter;
19+
private readonly _versionParameter: IRequiredCommandLineStringParameter;
1720
private readonly _subspaceNamesParameter: CommandLineStringListParameter;
1821

1922
public constructor(parser: RushCommandLineParser) {
@@ -77,7 +80,7 @@ export class BridgePackageAction extends BaseHotlinkPackageAction {
7780
linkedPackagePath: string,
7881
hotlinkManager: HotlinkManager
7982
): Promise<void> {
80-
const version: string = this._versionParameter.value!;
83+
const version: string = this._versionParameter.value;
8184
const subspaces: Set<Subspace> = this._getSubspacesToBridgeAsync();
8285
await Async.forEachAsync(
8386
subspaces,

libraries/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ Optional arguments:
178178
--version SEMVER_RANGE
179179
Specify which installed versions should be hotlinked.
180180
The default value is \\"*\\".
181-
--subspace SUBSPACE The name of the subspace to use for the bridge
181+
--subspace SUBSPACE The name of the subspace to use for the hotlinked
182182
package.
183183
"
184184
`;

0 commit comments

Comments
 (0)