PR feedback

Author: octogonz

libraries/rush-lib/src/logic/operations/WeightedOperationPlugin.ts

@@ -48,13 +48,13 @@ function weightOperations(
    */
   function _tryConvertPercentWeight(weight: `${number}%`): number {
     if (!percentageRegExp.test(weight)) {
-      throw new Error(`Expected a percentage string like "100%".`);
+      throw new Error(`Because the JSON value is a string, expecting a percentage like "23.4%".`);
     }
 
     const percentValue: number = parseFloat(weight.slice(0, -1));
 
     // Use as much CPU as possible, so we round down the weight here
-    return Math.floor((percentValue / 100) * availableParallelism);
+    return Math.max(1, Math.floor((percentValue / 100) * availableParallelism));
   }
 
   for (const [operation, record] of operations) {

libraries/rush-lib/src/schemas/rush-project.schema.json

@@ -110,7 +110,7 @@
               {
                 "type": "string",
                 "pattern": "^[1-9][0-9]*(\\.\\d+)?%$",
-                "description": "The number of concurrency units that this operation should take up, as a percent of `os.availableParallelism()`. At runtime this value will be clamped to the range `[1, rushParallelism]`, where `rushParallelism` is the requested parallelism to the current Rush command. To have this operation consume no concurrency, use the literal value `0`."
+                "description": "The number of concurrency units that this operation should take up, as a percent of `os.availableParallelism()`. At runtime this value will be clamped to the range `[1, rushParallelism]`, where `rushParallelism` is the requested parallelism to the current Rush command. To have this operation consume no concurrency, use the number 0 instead of a string."
               },
               {
                 "description": "The number of concurrency units that this operation should take up. At runtime this value will be clamped to the range `[0, rushParallelism]`, where `rushParallelism` is the requested parallelism to the current Rush command.",