fix: add preventAutoclose to ProblemCollector, inject strip-colors transform, make line/column optional in patterns, always wire problemCollector

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/d3363f24-2939-4850-85fb-b8b3eafa7a1e

Author: Copilot

libraries/node-core-library/src/FileError.ts

@@ -50,7 +50,7 @@ const uuidFileError: string = '37a4c772-2dc8-4c66-89ae-262f8cc1f0c1';
 const baseFolderEnvVar: string = 'RUSHSTACK_FILE_ERROR_BASE_FOLDER';
 
 const unixProblemMatcherPattern: IProblemPattern = {
-  regexp: '^\\[[^\\]]+\\]\\s+(Error|Warning):\\s+([^:]+):(\\d+):(\\d+)\\s+-\\s+(?:\\(([^)]+)\\)\\s+)?(.*)$',
+  regexp: '^\\[[^\\]]+\\]\\s+(Error|Warning):\\s+([^:\\s]+)(?::(\\d+)(?::(\\d+))?)?\\s+-\\s+(?:\\(([^)]+)\\)\\s+)?(.*)$',
   severity: 1,
   file: 2,
   line: 3,
@@ -61,7 +61,7 @@ const unixProblemMatcherPattern: IProblemPattern = {
 
 const vsProblemMatcherPattern: IProblemPattern = {
   regexp:
-    '^\\[[^\\]]+\\]\\s+(Error|Warning):\\s+([^\\(]+)\\((\\d+),(\\d+)\\)\\s+-\\s+(?:\\(([^)]+)\\)\\s+)?(.*)$',
+    '^\\[[^\\]]+\\]\\s+(Error|Warning):\\s+([^\\(\\s]+)(?:\\((\\d+)(?:,(\\d+))?\\))?\\s+-\\s+(?:\\(([^)]+)\\)\\s+)?(.*)$',
   severity: 1,
   file: 2,
   line: 3,

libraries/rush-lib/src/logic/operations/OperationExecutionRecord.ts

@@ -114,6 +114,8 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
     preventAutoclose: true
   });
   public readonly problemCollector: ProblemCollector = new ProblemCollector({
+    // Allow writing to this object after transforms have been closed. We clean it up manually in a finally block.
+    preventAutoclose: true,
     matcherJson: [
       {
         name: 'rushstack-file-error-unix',
@@ -322,14 +324,21 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
       //
       //                             +--> quietModeTransform? --> collatedWriter
       //                             |
-      // normalizeNewlineTransform --1--> stderrLineTransform --2--> projectLogWritable
+      // normalizeNewlineTransform --1--> stderrLineTransform --2--> projectLogWritable?
       //                                                        |
       //                                                        +--> stdioSummarizer
-      const destination: TerminalWritable = projectLogWritable
-        ? new SplitterTransform({
-            destinations: [projectLogWritable, stdioSummarizer, problemCollector]
-          })
-        : stdioSummarizer;
+      //                                                        |
+      //                                                        +--> removeColorsTransform --> problemCollector
+      const removeColorsTransform: TextRewriterTransform = new TextRewriterTransform({
+        destination: problemCollector,
+        removeColors: true
+      });
+
+      const destination: TerminalWritable = new SplitterTransform({
+        destinations: projectLogWritable
+          ? [projectLogWritable, stdioSummarizer, removeColorsTransform]
+          : [stdioSummarizer, removeColorsTransform]
+      });
 
       const stderrLineTransform: StderrLineTransform = new StderrLineTransform({
         destination,