Skip to content

Commit e9952f9

Browse files
committed
fix: comments
1 parent c4b6c52 commit e9952f9

2 files changed

Lines changed: 13 additions & 7 deletions

File tree

libraries/rush-lib/src/cli/actions/BridgePackageAction.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@ export class BridgePackageAction extends BaseHotlinkPackageAction {
4646
});
4747
}
4848

49-
public async hotlinkPackageAsync(linkedPackagePath: string, hotlinkManager: HotlinkManager): Promise<void> {
49+
protected async hotlinkPackageAsync(
50+
linkedPackagePath: string,
51+
hotlinkManager: HotlinkManager
52+
): Promise<void> {
5053
const version: string = this._versionParameter.value!;
5154
const subspace: Subspace = this.rushConfiguration.getSubspace(this._subspaceNameParameter.value!);
5255
await hotlinkManager.bridgePackageAsync(this.terminal, subspace, linkedPackagePath, version);

libraries/rush-lib/src/cli/actions/LinkPackageAction.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { RushConstants } from '../../logic/RushConstants';
1111
import { Async } from '@rushstack/node-core-library';
1212

1313
export class LinkPackageAction extends BaseHotlinkPackageAction {
14-
protected readonly _projectList: CommandLineStringListParameter;
14+
protected readonly _projectListParameter: CommandLineStringListParameter;
1515

1616
public constructor(parser: RushCommandLineParser) {
1717
super({
@@ -30,7 +30,7 @@ export class LinkPackageAction extends BaseHotlinkPackageAction {
3030
parser
3131
});
3232

33-
this._projectList = this.defineStringListParameter({
33+
this._projectListParameter = this.defineStringListParameter({
3434
parameterLongName: '--project',
3535
required: false,
3636
argumentName: 'PROJECT',
@@ -40,9 +40,9 @@ export class LinkPackageAction extends BaseHotlinkPackageAction {
4040
});
4141
}
4242

43-
protected async getProjectsToLinkAsync(): Promise<Set<RushConfigurationProject>> {
43+
private async _getProjectsToLinkAsync(): Promise<Set<RushConfigurationProject>> {
4444
const projectsToLink: Set<RushConfigurationProject> = new Set();
45-
const projectNames: readonly string[] = this._projectList.values;
45+
const projectNames: readonly string[] = this._projectListParameter.values;
4646

4747
if (projectNames.length > 0) {
4848
for (const projectName of projectNames) {
@@ -65,8 +65,11 @@ export class LinkPackageAction extends BaseHotlinkPackageAction {
6565
return projectsToLink;
6666
}
6767

68-
public async hotlinkPackageAsync(linkedPackagePath: string, hotlinkManager: HotlinkManager): Promise<void> {
69-
const projectsToLink: Set<RushConfigurationProject> = await this.getProjectsToLinkAsync();
68+
protected async hotlinkPackageAsync(
69+
linkedPackagePath: string,
70+
hotlinkManager: HotlinkManager
71+
): Promise<void> {
72+
const projectsToLink: Set<RushConfigurationProject> = await this._getProjectsToLinkAsync();
7073
await Async.forEachAsync(
7174
projectsToLink,
7275
async (project) => {

0 commit comments

Comments
 (0)