[heft] update storybook plugin to be compatible with v9 (#5492)

* [heft] update storybook to be compatible with v9

Also adds support for serve mode detection when using the heft-rspack-plugin

* code review changes

* fix ci issues

* Normalize versions.

* Rush update.

* Create separate v6 and v9 storybook test projects.

* Rush update.

* fixup! fix ci issues

* fixup! Create separate v6 and v9 storybook test projects.

* Rush change.

* fixup! Create separate v6 and v9 storybook test projects.

* fixup! Rush update.

* Bump html-webpack-plugin to the version that works with Webpack 5.

* Clean up the resoluion of the @storybook/react-webpack5 package.

* Don't run Storybook v9 under Node 18.

* fixup! Rush update.

---------

Co-authored-by: Taylor <ubermous@users.noreply.github.com>
Co-authored-by: Taylor Lodge <ubermouse@users.noreply.github.com>
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>

Author: 3 people

.github/workflows/ci.yml

@@ -12,6 +12,9 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          # When Node 18 is removed, remove the special cases in
+          # - build-tests-samples/heft-storybook-v9-react-tutorial/build.js
+          # - build-tests-samples/heft-storybook-v9-react-tutorial-app/build.js
           - NodeVersion: 18.20.x
             NodeVersionDisplayName: 18
             OS: ubuntu-latest

README.md

@@ -11,11 +11,11 @@
           "taskPlugin": {
             "pluginPackage": "@rushstack/heft-storybook-plugin",
             "options": {
-              "storykitPackageName": "heft-storybook-react-tutorial-storykit",
+              "storykitPackageName": "heft-storybook-v6-react-tutorial-storykit",
               "cliPackageName": "@storybook/react",
               "cliCallingConvention": "storybook6",
               "staticBuildOutputFolder": "dist",
-              "cwdPackageName": "heft-storybook-react-tutorial"
+              "cwdPackageName": "heft-storybook-v6-react-tutorial"
             }
           }
         }

build-tests-samples/heft-storybook-react-tutorial-app/README.md

@@ -1,5 +1,5 @@
 {
-  "name": "heft-storybook-react-tutorial-app",
+  "name": "heft-storybook-v6-react-tutorial-app",
   "description": "Building this project is a regression test for heft-storybook-plugin",
   "version": "1.0.0",
   "private": true,
@@ -9,11 +9,11 @@
     "_phase:test": ""
   },
   "dependencies": {
-    "heft-storybook-react-tutorial": "workspace: *"
+    "heft-storybook-v6-react-tutorial": "workspace: *"
   },
   "devDependencies": {
     "@rushstack/heft-storybook-plugin": "workspace:*",
     "@rushstack/heft": "workspace:*",
-    "heft-storybook-react-tutorial-storykit": "workspace:*"
+    "heft-storybook-v6-react-tutorial-storykit": "workspace:*"
   }
 }