[rush] Add --debug-build-cache-ids flag#5173
Merged
dmichon-msft merged 5 commits intomicrosoft:mainfrom Mar 27, 2025
Merged
Conversation
iclanton
approved these changes
Mar 27, 2025
dmichon-msft
commented
Mar 27, 2025
iclanton
approved these changes
Mar 27, 2025
D4N14L
approved these changes
Mar 27, 2025
D4N14L
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new flag
--debug-build-cache-idsto phased commands to help diagnose unexpected build cache misses.Details
Reworked the internals of cache id computation so that the build cache version and salt are applied only at the very end when converting the hash to a cache entry id.
Moved operation state hash computation to occur between
createOperationsandbeforeExecuteOperationsto ensure that the hashes are computed based on the established operation graph, and that no mutation of the runtime graph has had a chance to occur.Added
getStateHash()andgetStateHashComponents()methods toIOperationExecutionResultso that plugins may leverage that information for debugging. Computation of final build cache ids from the state hash is accessible via theBuildCacheConfigurationobject.Also updates the sort order of the
resultsobject so that operations are in lexicographical order by name. This impacts the default result summary and makes it more readable.How it was tested
Example output:

Impacted documentation
The documentation of the operation execution results.