Skip to content

Bump TypeScript to 5.9. #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliw00d wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Bump TypeScript to 5.9. #5550

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cf96a9a
Bump TypeScript to 5.9.
eliw00d Jan 13, 2026
5ee3c07
remove change files
eliw00d Jan 13, 2026
6a31a77
rush change
eliw00d Jan 13, 2026
eb13300
fix build issue
eliw00d Jan 13, 2026
37be101
rush change
eliw00d Jan 13, 2026
1f777d2
set skipLibCheck to true due to api-extractor build issue
eliw00d Jan 13, 2026
5cf9ca3
Update common/changes/@rushstack/heft-isolated-typescript-transpile-p…
eliw00d Mar 23, 2026
51cc82f
Merge remote-tracking branch 'upstream/main' into ts-5.9
eliw00d Mar 23, 2026
e6c6996
apply fix for build errors
eliw00d Mar 23, 2026
729d770
run rush change
eliw00d Mar 23, 2026
97835ea
useProjectTypescriptVersion
eliw00d Mar 23, 2026
7fca36d
revert
eliw00d Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api-extractor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"resolve": "~1.22.1",
"semver": "~7.5.4",
"source-map": "~0.6.1",
"typescript": "5.8.2"
"typescript": "5.9.3"
},
"devDependencies": {
"@rushstack/heft": "1.1.7",
Expand Down
2 changes: 1 addition & 1 deletion apps/lockfile-explorer-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
"@types/react-dom": "19.2.3",
"eslint": "~9.37.0",
"local-web-rig": "workspace:*",
"typescript": "5.8.2"
"typescript": "5.9.3"
}
}
2 changes: 1 addition & 1 deletion apps/rush-mcp-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@rushstack/heft": "workspace:*",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"@types/node": "20.17.19"
}
}
2 changes: 1 addition & 1 deletion apps/trace-import/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@rushstack/ts-command-line": "workspace:*",
"resolve": "~1.22.1",
"semver": "~7.5.4",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
},
"devDependencies": {
"@rushstack/heft": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion apps/zipsync/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"dependencies": {
"@rushstack/terminal": "workspace:*",
"@rushstack/ts-command-line": "workspace:*",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"@rushstack/lookup-by-path": "workspace:*"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/heft-node-basic-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"@types/node": "20.17.19",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-node-jest-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"@types/node": "20.17.19",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-serverless-stack-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@
"constructs": "~10.0.98",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-storybook-v6-react-tutorial-storykit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"react": "~17.0.2",
"style-loader": "~2.0.0",
"terser-webpack-plugin": "~3.0.8",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~4.47.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/heft-storybook-v6-react-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"local-eslint-config": "workspace:*",
"source-map-loader": "~1.1.3",
"style-loader": "~2.0.0",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~4.47.0"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-storybook-v9-react-tutorial-storykit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"react": "~19.2.3",
"style-loader": "~2.0.0",
"terser-webpack-plugin": "~3.0.8",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~5.103.0",
"storybook": "~9.1.6",
"@testing-library/dom": "~7.21.4"
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/heft-storybook-v9-react-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"local-eslint-config": "workspace:*",
"source-map-loader": "~1.1.3",
"style-loader": "~2.0.0",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~5.103.0",
"storybook": "~9.1.6",
"@testing-library/dom": "~7.21.4",
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/heft-webpack-basic-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"local-eslint-config": "workspace:*",
"source-map-loader": "~3.0.1",
"style-loader": "~3.3.1",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~5.103.0"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/packlets-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@rushstack/heft-typescript-plugin": "workspace:*",
"@types/node": "20.17.19",
"eslint": "~8.57.0",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests-subspace/typescript-newest-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"@rushstack/heft": "workspace:*",
"eslint": "~9.25.1",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
},
"dependenciesMeta": {
"@rushstack/heft": {
Expand Down
2 changes: 1 addition & 1 deletion build-tests/eslint-7-11-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@typescript-eslint/parser": "~6.19.0",
"eslint": "7.11.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/eslint-7-7-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@typescript-eslint/parser": "~6.19.0",
"eslint": "7.7.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/eslint-7-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@typescript-eslint/parser": "~6.19.0",
"eslint": "~7.30.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/eslint-8-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~8.57.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/eslint-9-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@types/node": "20.17.19",
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~9.37.0",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/eslint-bulk-suppressions-test-flat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/eslint-bulk-suppressions-test-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
"eslint-8.23": "npm:eslint@8.23.1",
"eslint-oldest": "npm:eslint@8.6.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/eslint-bulk-suppressions-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~8.57.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/hashed-folder-copy-plugin-webpack5-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@rushstack/heft-webpack5-plugin": "workspace:*",
"@types/webpack-env": "1.18.8",
"html-webpack-plugin": "~5.5.0",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack-bundle-analyzer": "~4.5.0",
"webpack": "~5.103.0"
}
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-example-lifecycle-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
"@types/node": "20.17.19",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-example-plugin-01/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"@types/tapable": "1.0.6",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-example-plugin-02/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@
"eslint": "~9.37.0",
"heft-example-plugin-01": "workspace:*",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-fastify-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@types/node": "20.17.19",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
},
"dependencies": {
"fastify": "~3.16.1"
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-jest-preset-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"@types/heft-jest": "1.0.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-jest-reporters-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"@types/node": "20.17.19",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-minimal-rig-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"_phase:build": ""
},
"dependencies": {
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"@microsoft/api-extractor": "workspace:*",
"@rushstack/heft-api-extractor-plugin": "workspace:*",
"@rushstack/heft-jest-plugin": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-node-everything-esm-module-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
"heft-example-plugin-02": "workspace:*",
"local-eslint-config": "workspace:*",
"tslint": "~5.20.1",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-node-everything-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
"heft-example-plugin-02": "workspace:*",
"local-eslint-config": "workspace:*",
"tslint": "~5.20.1",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-parameter-plugin-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"@types/heft-jest": "1.0.1",
"@types/node": "20.17.19",
"heft-parameter-plugin": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-parameter-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@types/node": "20.17.19",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
},
"dependencies": {
"@rushstack/node-core-library": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-rspack-everything-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@types/node": "20.17.19",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"@rspack/core": "~1.6.0-beta.0"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-sass-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"react-dom": "~19.2.3",
"react": "~19.2.3",
"style-loader": "~2.0.0",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~4.47.0"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-swc-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"@types/webpack-env": "1.18.8",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-typescript-composite-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"tslint": "~5.20.1",
"typescript": "~5.8.2"
"typescript": "~5.9.3"
}
}
1 change: 1 addition & 0 deletions build-tests/heft-typescript-v3-test/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"compilerOptions": {
"outDir": "lib",
"rootDir": "src",
"skipLibCheck": true,
Copy link
Copy Markdown
Author

@eliw00d eliw00d Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed like the least invasive way to resolve the build issue related to api-extractor. If there's a better way, let me know!

Copy link
Copy Markdown
Member

@iclanton iclanton Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue that shows up without this?

Copy link
Copy Markdown
Author

@eliw00d eliw00d Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iclanton I ran into these build errors: https://github.com/microsoft/rushstack/actions/runs/20974606343/job/60286286855#step:8:7346

Copy link
Copy Markdown
Author

@eliw00d eliw00d Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I have time this week I'll fix this PR up and look at removing this.

Copy link
Copy Markdown
Author

@eliw00d eliw00d Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few things but it seems like the heft-typescript-v3-test + typescript@5.9 + @types/node@17 don't work well together and setting skipLibCheck to true was the only way to avoid the new 5.9 types from conflicting.


"forceConsistentCasingInFileNames": true,
"jsx": "react",
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-webpack4-everything-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"local-eslint-config": "workspace:*",
"source-map-loader": "~1.1.3",
"tslint": "~5.20.1",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~4.47.0"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-webpack5-everything-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"local-eslint-config": "workspace:*",
"source-map-loader": "~3.0.1",
"tslint": "~5.20.1",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~5.103.0"
}
}
2 changes: 1 addition & 1 deletion build-tests/localization-plugin-test-03/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"html-webpack-plugin": "~4.5.2",
"local-node-rig": "workspace:*",
"ts-loader": "6.0.0",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~4.47.0",
"webpack-bundle-analyzer": "~4.5.0",
"webpack-dev-server": "~4.9.3"
Expand Down
2 changes: 1 addition & 1 deletion build-tests/set-webpack-public-path-plugin-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@types/webpack-env": "1.18.8",
"eslint": "~8.57.0",
"html-webpack-plugin": "~5.5.0",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~5.103.0"
}
}
2 changes: 1 addition & 1 deletion build-tests/webpack-local-version-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@types/webpack-env": "1.18.8",
"eslint": "~9.25.1",
"html-webpack-plugin": "~5.5.0",
"typescript": "~5.8.2",
"typescript": "~5.9.3",
"webpack": "~5.103.0"
}
}
10 changes: 10 additions & 0 deletions common/changes/@microsoft/api-extractor/ts-5.9_2026-01-13-21-56.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/api-extractor",
"comment": "Upgrade the bundled compiler engine to TypeScript 5.9.3",
"type": "minor"
}
],
"packageName": "@microsoft/api-extractor"
}
Loading