Skip to content

Add @rushstack/storybook-telemetry-stub package #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 8 commits into from
Closed

Add @rushstack/storybook-telemetry-stub package #5695

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
397c944
Initial plan
Copilot Mar 10, 2026
52d1afc
Add @rushstack/storybook-telemetry-stub package with no-op stubs and …
Copilot Mar 10, 2026
b21f859
Fix lint warnings and test loading issues for storybook-telemetry-stub
Copilot Mar 10, 2026
4e51f83
Address all review feedback: rename folder, fix tests, update README,…
Copilot Mar 11, 2026
5871f3b
Move @storybook/telemetry to nonbrowser-approved-packages.json and us…
Copilot Mar 11, 2026
7501910
Add Rush change file for @rushstack/storybook-telemetry-stub
Copilot Mar 11, 2026
4150f44
Revert lockfiles to main and rerun rush update
Copilot Mar 11, 2026
46ac29c
Remove storybook v7 dependency, hardcode v7 expected exports in tests…
Copilot Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/config/rush/browser-approved-packages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
"name": "@rushstack/rush-vscode-command-webview",
"allowedCategories": [ "vscode-extensions" ]
},
{
"name": "@storybook/telemetry",
"allowedCategories": [ "libraries" ]
},
Comment thread
dmichon-msft marked this conversation as resolved.
Outdated
{
"name": "@ungap/structured-clone",
"allowedCategories": [ "libraries" ]
Expand Down
16 changes: 12 additions & 4 deletions common/config/rush/nonbrowser-approved-packages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,6 @@
"name": "@rushstack/heft-dev-cert-plugin",
"allowedCategories": [ "libraries", "tests" ]
},
{
"name": "@rushstack/heft-static-asset-typings-plugin",
"allowedCategories": [ "libraries", "tests" ]
},
{
"name": "@rushstack/heft-isolated-typescript-transpile-plugin",
"allowedCategories": [ "tests" ]
Expand Down Expand Up @@ -242,6 +238,10 @@
"name": "@rushstack/heft-serverless-stack-plugin",
"allowedCategories": [ "tests" ]
},
{
"name": "@rushstack/heft-static-asset-typings-plugin",
"allowedCategories": [ "libraries", "tests" ]
},
{
"name": "@rushstack/heft-storybook-plugin",
"allowedCategories": [ "tests" ]
Expand Down Expand Up @@ -474,6 +474,14 @@
"name": "@storybook/react-webpack5",
"allowedCategories": [ "libraries", "tests" ]
},
{
"name": "@storybook/telemetry-7",
"allowedCategories": [ "libraries" ]
},
{
"name": "@storybook/telemetry-8",
"allowedCategories": [ "libraries" ]
},
{
"name": "@storybook/theming",
"allowedCategories": [ "tests" ]
Expand Down
3 changes: 2 additions & 1 deletion common/config/rush/pnpm-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,8 @@
// TODO: Remove once Heft is 1.0.0
"allowAny": ["@rushstack/heft"],
"allowedVersions": {
"webpack": "^4 || ^5"
"webpack": "^4 || ^5",
"storybook": "*"
}
},

Expand Down
825 changes: 412 additions & 413 deletions common/config/subspaces/build-tests-subspace/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion common/config/subspaces/build-tests-subspace/repo-state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
{
"pnpmShrinkwrapHash": "c395a90b30bd67a31beb1d1b08be9aecb02de265",
"pnpmShrinkwrapHash": "90d99f917f49daeaba32bb42a586c2203d338d37",
"preferredVersionsHash": "550b4cee0bef4e97db6c6aad726df5149d20e7d9",
"packageJsonInjectedDependenciesHash": "fa90a0a032a0046e646e8751bbc6d0be86a4dda1"
}
Loading
Loading