Override js-yaml@<=2.0.4 to 3.14.2 to fix code execution vulnerability#5721
Closed
BPapp-MS wants to merge 1 commit intomicrosoft:mainfrom
Closed
Override js-yaml@<=2.0.4 to 3.14.2 to fix code execution vulnerability#5721BPapp-MS wants to merge 1 commit intomicrosoft:mainfrom
BPapp-MS wants to merge 1 commit intomicrosoft:mainfrom
Conversation
BPapp-MS
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
Member
|
bump diff: nodeca/js-yaml@2.0.4...3.14.2 v2 to v3 seems to have a refactor bump. but still take a closer look at the API and behavior changes. consider bumping the packages that are bringing in js-yaml dependency to rushstack. |
Contributor
Author
|
Need to update the override to include lower versions, will make a new PR when ready. Will look into bumping intermediate layers as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overrides earlier versions of js-yaml, which had a code execution vulnerability. major version 3 is the easiest to override to, since earlier versions required replacing .load() with .safeLoad().
Details
Trying to address the following vulnerability:
https://nealpoole.com/blog/2013/06/code-execution-via-yaml-in-js-yaml-nodejs-module/
How it was tested
Ran rush test
Impacted documentation
N/A