Feature: Suppression Expression Support (#2530)#2575
Merged
Conversation
* Feature: Added GUID list and query suppression support * Fixed bug: suppress options with guids type * fixed bug in SuppressOptions with guids options * Bug: Allowed using results-guids and expression arguments together. * chore: typo in log message * feat: console log number of suppressions applied * bug: comma delimit results arg * Fixed bug with ResultsGuids and added debug output * fixed bug with ResultsGuids union to Query guids * WIP - Added IsSuppressed evaluator and updated unit tests * Fixed: Changes requested for #2530 * bug: validate result guid values are not whitespace * bug: empty search suppresses all results * bug: skip duplicate suppression entries * bug: suppress visitor multiple test cases * bug: fixed merge command unit test failure * chore: formatting failures * chore: codeql warnings * chore: docs * bug: suppression expiration no expiry logic flaw * docs: release notes + query mode updates * bug: fixed failing suppression test case * feat: suppress expiryUtc command argument * bug: reverted bad test data Co-authored-by: Andrew Guggenberger <andrew.guggenberger@pumasecurity.io> Co-authored-by: Andrew Guggenberger <aguggenberger@users.noreply.github.com>
ejohn20
requested review from
EasyRhinoMSFT,
cfaucon,
marmegh and
michaelcfanning
as code owners
Collaborator
Author
|
@michaelcfanning Still working through a few modifications required due to the result guid changing from a string to a Guild?. I'll report back when this is stable. |
Resolve conflicts and update the suppression-expression feature for the result/suppression guid migration from string to Guid?: - RandomSarifLogGenerator.GenerateFakeResults now takes List<Guid>; SuppressVisitor compares result.Guid.ToString(); SuppressCommand projects matched result guids to strings. - Port the suppress/query release notes to the relocated root ReleaseHistory.md (terse house style) and drop the deleted src/ReleaseHistory.md. - Adopt dev's FluentAssertions BeCloseTo(TimeSpan) signature in the suppression tests; give the merge-dedup test a stable guid so cross-input results stay value-identical. - Remove a stray 'using Kusto.Cloud.Platform.Utils' import in SuppressCommand. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The merge commit captured the auto-staged (pre-fix) versions of files I edited after resolving conflicts. This re-applies them: SuppressVisitor/SuppressCommand guid-to-string projection, the List<Guid> test call sites, the stable merge-dedup guid, and the Kusto using removal. Also fixes the trailing newline check-format flagged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request adds the features described in #2529