-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Python: fix(python/redis): fix FT.CREATE prefix format and silent delete failure #13907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EaCognitive
wants to merge
4
commits into
microsoft:main
Choose a base branch
from
EaCognitive:fix-python-redis-connector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−5
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
15c33da
fix(python/redis): fix FT.CREATE prefix format and silent delete failure
EaCognitive 562f8be
test(python/redis): add tests for prefixed delete and index prefix li…
EaCognitive 6d55d4e
Merge remote-tracking branch 'upstream/main' into fix-python-redis-co…
EaCognitive 0f05433
test(python/redis): cover index prefix command args
EaCognitive File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug fix is not covered by any test. The existing
test_deleteat line 274 oftest_redis_store.pyonly uses collections withprefix_collection_name_to_key_names=False, so_get_redis_keyreturns the key unchanged. Please add a test that usescollection_with_prefix_jsonand asserts the mock'sdeletewas called with'test:id1'(the prefixed key).