.Net: VectorData connector bugfix release#13928
Merged
westey-m merged 5 commits intomicrosoft:feature-vectordata-subset-release-2from Apr 29, 2026
Merged
.Net: VectorData connector bugfix release#13928westey-m merged 5 commits intomicrosoft:feature-vectordata-subset-release-2from
westey-m merged 5 commits intomicrosoft:feature-vectordata-subset-release-2from
Conversation
…iterals (microsoft#13900) In the SQL Server MEVD provider, table/schema/column names embedded inside SQL string literals (`N'...'`) were not escaping single quotes. This could produce broken SQL when names contain single quotes. For example, a table named `it's` would generate: ```sql IF OBJECT_ID(N'[dbo].[it's]', N'U') IS NULL ``` which is invalid SQL. The fix produces: ```sql IF OBJECT_ID(N'[dbo].[it''s]', N'U') IS NULL ``` ### Changes Added `AppendTableNameInsideLiteral` and `AppendIdentifierInsideLiteral` helper methods that escape single quotes by doubling them, and updated the 5 call sites where identifiers appear inside string literals: - `OBJECT_ID` in `CreateTable` (ifNotExists check) - `OBJECT_ID` in full-text index PK lookup - Dynamic SQL table name, column names, and catalog name for full-text indexes ### Tests Added unit tests for `AppendTableNameInsideLiteral`, `AppendIdentifierInsideLiteral`, and a `CreateTable_WithSingleQuoteInName` integration test. All 283 tests pass (unit + conformance). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…3902) ### Motivation and Context ### Description - Add backslash escaping to redis text search values ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
github-actions
Bot
changed the title
roji
approved these changes
Apr 28, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
<!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
westey-m
merged commit 9cf7f01
into
microsoft:feature-vectordata-subset-release-2
10 checks passed
SergeyMenshykh
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We need to release only a subset of connectors so creating a fork with only the fixes required.
Description
Contribution Checklist