Remove interlocked from fast path.

mjp41 · mjp41 · commit 0087c2937727 · 2026-02-19T13:42:37.000Z
diff --git a/src/snmalloc/ds_core/stats.h b/src/snmalloc/ds_core/stats.h
@@ -77,7 +77,8 @@ namespace snmalloc
   public:
     void operator++(int)
     {
-      value.fetch_add(1, stl::memory_order_relaxed);
+      auto old = value.load(stl::memory_order_relaxed);
+      value.store(old + 1, stl::memory_order_relaxed);
     }
 
     void operator+=(const MonotoneLocalStat& other)
@@ -88,7 +89,8 @@ namespace snmalloc
 
     void operator+=(size_t v)
     {
-      value.fetch_add(v, stl::memory_order_relaxed);
+      auto old = value.load(stl::memory_order_relaxed);
+      value.store(old + v, stl::memory_order_relaxed);
     }
 
     size_t operator*()

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ namespace snmalloc`
`77`	`77`	`public:`
`78`	`78`	`void operator++(int)`
`79`	`79`	`{`
`80`		`- value.fetch_add(1, stl::memory_order_relaxed);`
	`80`	`+ auto old = value.load(stl::memory_order_relaxed);`
	`81`	`+ value.store(old + 1, stl::memory_order_relaxed);`
`81`	`82`	`}`
`82`	`83`
`83`	`84`	`void operator+=(const MonotoneLocalStat& other)`
`@@ -88,7 +89,8 @@ namespace snmalloc`
`88`	`89`
`89`	`90`	`void operator+=(size_t v)`
`90`	`91`	`{`
`91`		`- value.fetch_add(v, stl::memory_order_relaxed);`
	`92`	`+ auto old = value.load(stl::memory_order_relaxed);`
	`93`	`+ value.store(old + v, stl::memory_order_relaxed);`
`92`	`94`	`}`
`93`	`95`
`94`	`96`	`size_t operator*()`