closeTab: show confirmation dialog when tab has multiple panes#19976
Closed
WolffM wants to merge 3 commits into
Closed
closeTab: show confirmation dialog when tab has multiple panes#19976WolffM wants to merge 3 commits into
WolffM wants to merge 3 commits into
Conversation
microsoft-github-policy-service
Bot
added
Issue-Task
WolffM
force-pushed
the
fix/5301-closetab-show-confirmation-dialog-when-tab-has-mul
branch
from
a4441a6 to
62b4e82
Compare
Author
|
@microsoft-github-policy-service agree |
Member
|
Thanks for the contribution! I've reviewed the PR and tested it, it works great! That said, #19944 conflicts with this one and covers a few more scenarios. There's also some discussion over there about adding a "don't ask me again" checkbox, which I think would complement these warnings pretty well. For that reason, I'm closing this PR in favor of that one. That said, I'm taking over #19944, so definitely hop over there and share your opinions on the desired UX. I want to make sure we've got all our bases covered. Thanks! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5301: closeTab: show confirmation dialog when tab has multiple panes
Changes
This PR addresses the issue described above. Changes were developed on the
fix/5301-closetab-show-confirmation-dialog-when-tab-has-mulbranch.Related Issue