fix(resizePane): Mark as handled only when resize succeeds#20001
Merged
Conversation
This fix addresses issue microsoft#19983 where resizePane actions unconditionally consume keystrokes even when no resize can occur. The fix follows the same pattern used for moveFocus and swapPane fixes: - Changed Tab::ResizePane to return bool indicating success - Changed TerminalPage::_ResizePane to return bool from ResizePane - Updated _HandleResizePane to set args.Handled() based on whether resize succeeded This allows the keychord to propagate to the terminal when no resize can occur, matching the behavior of moveFocus and swapPane (GH#6129).
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DHowett
approved these changes
Mar 20, 2026
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
looks good - thanks! merge will be blocked until you agree to the CLA of course.
Contributor
Author
|
@microsoft-github-policy-service agree |
Comment on lines
+2800
to
2801
| return tabImpl->ResizePane(direction); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| return tabImpl->ResizePane(direction); | |
| } | |
| return tabImpl->ResizePane(direction); | |
| } | |
| return false; |
CI pipeline is failing because this warning is treated as an error:
##[warning]src\cascadia\TerminalApp\TerminalPage.cpp(2802,0): Warning C4715: 'winrt::TerminalApp::implementation::TerminalPage::_ResizePane': not all control paths return a value
Simple fix. 😊
Member
|
code format failed too -- suggesting the wrong line endings (perhaps on behalf of whatever tool was used to author this code) |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlos-zamora
approved these changes
May 5, 2026
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Thanks for doing this! Sorry for the delay!
Qmoony
pushed a commit
to Qmoony/terminal
that referenced
this pull request
May 11, 2026
…#20001) This fix addresses issue microsoft#19983 where resizePane actions unconditionally consume keystrokes even when no resize can occur. The fix follows the same pattern used for moveFocus and swapPane fixes: - Changed Tab::ResizePane to return bool indicating success - Changed TerminalPage::_ResizePane to return bool from ResizePane - Updated _HandleResizePane to set args.Handled() based on whether resize succeeded This allows the keychord to propagate to the terminal when no resize can occur, matching the behavior of moveFocus and swapPane (microsoft#6129). Closes microsoft#19983 --------- Co-authored-by: nmurrell07 <nmurrell07@users.noreply.github.com> Co-authored-by: Dustin L. Howett <dustin@howett.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses issue #19983 where resizePane actions unconditionally consume keystrokes even when no resize can occur.
The fix follows the same pattern used for moveFocus and swapPane fixes:
This allows the keychord to propagate to the terminal when no resize can occur, matching the behavior of moveFocus and swapPane (GH#6129).