Add toast notification infrastructure#20010
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
Author
|
Some minor changes from the PR this was based on:
|
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 24, 2026
carlos-zamora
force-pushed
the
dev/cazamor/toast/base
branch
from
4357c17 to
aeb531f
Compare
## Summary of the Pull Request Targets #20010 Manually assign an AUMID to our process when we're running unpackaged. Main difference from #19937 is what AUMID we use. Before, it was per branding, but the `WindowEmperor` already appends an exe path hash for unpackaged instances to prevent crosstalk. Here, we're just using the same pattern: `Microsoft.WindowsTerminal.<hash>`. Heavily based on #19937 Co-authored by @zadjii-msft
carlos-zamora
added a commit
that referenced
this pull request
Apr 6, 2026
carlos-zamora
added a commit
that referenced
this pull request
Apr 8, 2026
This comment was marked as resolved.
This comment was marked as resolved.
lhecker
approved these changes
Apr 22, 2026
This comment has been minimized.
This comment has been minimized.
lhecker
approved these changes
Apr 29, 2026
carlos-zamora
added a commit
that referenced
this pull request
May 4, 2026
## Summary of the Pull Request Targets #20010 Adds another `bellStyle` flag option. This sends a windows toast notification to the user when a BEL is encountered - [X] Closes #18605 - [ ] Documentation updated Heavily based on #19936 Co-authored by @zadjii-msft
Qmoony
pushed a commit
to Qmoony/terminal
that referenced
this pull request
May 11, 2026
## Summary of the Pull Request Adds the infrastructure for toast notifications. Breakdown: - `DesktopNotification`: - `DesktopNotificationArgs` includes the struct to group all notification-related data together. - `SendNotification()` actually sends it - `AppCommandlineArgs.cpp`: added a check for the `--from-toast` no-op sentinel; ensures no new window is created - Most of the other changes are just bubbling up the notification from the `TerminalPaneContent` to `TerminalPage` - `TabManagement.cpp`: `_SendDesktopNotification()` does the final packaging of the notification before calling the `DesktopNotification` API This supports finding the right tab when it's been reordered or even moved to a new window! This also has expanded to support finding the right pane, which is resilient to pane swaps/closing too. When the pane can't be found, we just fallback to the tab. If the pane is already focused, we don't send a notification. This simply adds the infrastructure! Looks like nothing can actually take advantage of it yet, but it's been tested with the changes in microsoft#20011. Heavily based on microsoft#19935 Co-authored by @zadjii-msft
Qmoony
pushed a commit
to Qmoony/terminal
that referenced
this pull request
May 11, 2026
## Summary of the Pull Request Targets microsoft#20010 Adds another `bellStyle` flag option. This sends a windows toast notification to the user when a BEL is encountered - [X] Closes microsoft#18605 - [ ] Documentation updated Heavily based on microsoft#19936 Co-authored by @zadjii-msft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds the infrastructure for toast notifications. Breakdown:
DesktopNotification:DesktopNotificationArgsincludes the struct to group all notification-related data together.SendNotification()actually sends itAppCommandlineArgs.cpp: added a check for the--from-toastno-op sentinel; ensures no new window is createdTerminalPaneContenttoTerminalPageTabManagement.cpp:_SendDesktopNotification()does the final packaging of the notification before calling theDesktopNotificationAPIThis supports finding the right tab when it's been reordered or even moved to a new window!
This also has expanded to support finding the right pane, which is resilient to pane swaps/closing too. When the pane can't be found, we just fallback to the tab.
If the pane is already focused, we don't send a notification.
This simply adds the infrastructure! Looks like nothing can actually take advantage of it yet, but it's been tested with the changes in #20011.
Heavily based on #19935
Co-authored by @zadjii-msft