Add New Tab Submenu to System Menu#20034
Open
etbala wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
DHowett
requested changes
Mar 30, 2026
Member
|
(otherwise, this is very cool and aiming in the right direction!) |
Contributor
Author
|
Moved building the list of profiles to the TerminalPage (and took advantage of the Action engine in the process). |
| @@ -0,0 +1,40 @@ | |||
| Ccc | |||
| changelists | |||
Contributor
Author
There was a problem hiding this comment.
Not modified in this PR.
| pri | ||
| prioritization | ||
| rcv | ||
| screenshots |
Contributor
Author
There was a problem hiding this comment.
Not modified in this PR.
08f117a to
00b66c0
Compare
00b66c0 to
b0aeda5
Compare
Contributor
Author
|
@DHowett been a little while since I updated the branch so I rebased to main. Anything else you want me to change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #19538.
Adds a new tab submenu to the system menu that shows the different profiles available when creating a new tab normally.
Example:

Validation Steps Performed
(default)is visible on default profile)I was unsure if I should be adding any tests here, so I haven't done that (but I can if necessary).