Clarify default new-tab command in help#20176
Conversation
|
@microsoft-github-policy-service agree |
|
Hi maintainers, just checking whether there is anything else I should adjust here. This PR addresses #9585 and keeps the change scoped to the root help text plus the related test. |
zadjii-msft
left a comment
There was a problem hiding this comment.
Full local C++/TAEF tests were not run because msbuild is not available on this machine's PATH
That would suggest to me that you haven't built and run this code locally? That does seem to me like it would be the bear minimum requirement to filing a PR.
Can you please build this yourself locally, and add a screenshot of it running?
Moreso - I worry that this .footer leaks onto the output of all of the subcommands as well, resulting in wt sp --help also mentioning that the default subcommand is new-tab. That seems like noise to me.
|
@zadjii-msft Sorry about that. You were right to call this out. I had not fully set up the local TAEF/UAP test environment before posting the earlier note. I have now set it up locally, built the relevant Debug x64 test projects, and ran the command line parser tests locally. You were also right about the Local validation:
|
|
That's a screenshot of the tests running. Show me the message. |
You're right, the previous screenshot only showed the tests running, not the actual message. Result: I ran: Result: |
|
I'm sorry, your AI bot seems unable to comprehend what we are asking for :( |

Summary of the Pull Request
Clarifies the top-level
wthelp output for the implicitnew-tabbehavior. When no command is specified,wttreats the command line asnew-tab; the help text now states that and points users towt new-tab --helpfor options such as-d,--startingDirectory.References and Relevant Issues
Fixes #9585
Detailed Description of the Pull Request / Additional comments
This adds a CLI11 footer to the root command-line parser, backed by a new
CmdHelpFooterresource string. It also updates the existing simple help test to assert that the top-level help mentionsnew-tab,wt new-tab --help, and-d,--startingDirectory.Validation Steps Performed
src/cascadia/TerminalApp/Resources/en-US/Resources.reswas XML successfully.msbuildis not available on this machine's PATH.PR Checklist