Skip to content

Update styling of Actions page#20215

Draft
carlos-zamora wants to merge 4 commits into
mainfrom
dev/cazamor/sui-rejuv/actions
Draft

Update styling of Actions page#20215
carlos-zamora wants to merge 4 commits into
mainfrom
dev/cazamor/sui-rejuv/actions

Conversation

@carlos-zamora
Copy link
Copy Markdown
Member

Summary of the Pull Request

Updates the Actions and Edit Action pages according to the mockups in #20036. Notable changes:

  • KeyChordVisual: new control to display the key bindings. Bound to a KeyChord.
  • SettingsCardStyle: styling to look like a SettingContainer without actually being one. Used in the list of actions so that we don't get a warning for them being SettingContainers. Can be used in the color schemes page later for consistency.
  • Added a "..." (view all) button that is always visible. This shows all key bindings associated with an action.

Validation Steps Performed

Scenarios:

  • Actions page:
    • key chord visuals are legible
    • "view all" button displays other key bindings
    • clicking on entry or pencil navigates to Edit Action page
    • accessibility testing
  • Edit Action page:
    • key bindings expander starts expanded when key bindings are defined
    • accessibility testing

PR Checklist

Related to #17000

@carlos-zamora
Copy link
Copy Markdown
Member Author

carlos-zamora commented May 12, 2026

Notes

  • Actions.xaml:
    • hover on item should cover left/right edge
    • flyout with multiple key bindings (i.e. "copy text") should have a separator between each one
    • rename "Actions" title to "Shortcuts"
  • EditAction.xaml:
    • improve key listener control (focus issues when navigating w/ keyboard) DEFERRED

@carlos-zamora carlos-zamora marked this pull request as ready for review May 12, 2026 21:43
@carlos-zamora
Copy link
Copy Markdown
Member Author

Feedback

  • Consider adding a +# to make it more immediately clear that there's more associated shortcuts
  • Adding a shortcut should focus the listener
  • deleting an empty shortcut should not prompt for confirmation

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs-Tag-Fix Doesn't match tag requirements label May 14, 2026
@DHowett
Copy link
Copy Markdown
Member

DHowett commented May 14, 2026

also

  • ... usually opens up a menu

@carlos-zamora carlos-zamora removed the Needs-Tag-Fix Doesn't match tag requirements label May 15, 2026
@carlos-zamora carlos-zamora marked this pull request as draft May 20, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants