Refactor ConsoleArguments to use in-class initializers and remove redundant = operator (#962)#20248
Open
MichaelK05-dev wants to merge 1 commit into
Open
Refactor ConsoleArguments to use in-class initializers and remove redundant = operator (#962)#20248MichaelK05-dev wants to merge 1 commit into
MichaelK05-dev wants to merge 1 commit into
Conversation
…undant = operator (microsoft#962)
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR refactors the ConsoleArguments class to use in-class member initializers for members with constant or default values, replacing equivalent entries in the constructor initializer list.
This change aligns the class with C++ Core Guidelines C.48 (“Prefer in-class initializers to member initializers in constructors for constant initializers”) while preserving existing behavior.
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
src/host/ConsoleArguments.hpp
Examples include:
_headless,
_width,
_height,
_forceV1,
_runAsComServer,
_forceNoHandoff
src/host/ConsoleArguments.cpp
Validation Steps Performed
Manual Verification