Merge branch 'main' into guyllian.gomez/yarn-pnp

Author: GGomez99

.devcontainer/devcontainer.json

@@ -13,7 +13,8 @@
         },
         "ghcr.io/devcontainers-extra/features/dprint-asdf:2": {
             "version": "latest"
-        }
+        },
+        "ghcr.io/devcontainers/features/github-cli:1": {}
     },
 
     // Use 'forwardPorts' to make a list of ports inside the container available locally.

.github/actions/setup-go/action.yml

@@ -5,12 +5,6 @@ inputs:
   go-version:
     description: Go version to set up in go-install.ps1 format
     default: 'go1.26'
-  create:
-    description: Create the cache
-    default: 'false'
-  lint-cache:
-    description: Restore the golangci-lint cache
-    default: 'false'
 
 runs:
   using: composite
@@ -54,117 +48,3 @@ runs:
           GOBIN="$(go env GOPATH)/bin"
         fi
         echo "$GOBIN" >> $GITHUB_PATH
-
-    # Avoid hardcoding the cache keys more than once.
-    - name: Get cache info
-      shell: bash
-      id: cache-info
-      env:
-        MODULES_KEY: go-modules-${{ runner.os }}-msft-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
-        LINT_KEY: golangci-lint-${{ runner.os }}-msft-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
-        BUILD_KEY: go-build-cache-${{ runner.os }}-msft-${{ steps.install-go.outputs.go-version }}
-      run: |
-        echo "modules-key=$MODULES_KEY" >> $GITHUB_OUTPUT
-        echo "lint-key=$LINT_KEY" >> $GITHUB_OUTPUT
-        echo "build-key=$BUILD_KEY" >> $GITHUB_OUTPUT
-        echo "GOLANGCI_LINT_CACHE=$RUNNER_TEMP/golangci-lint-cache" >> $GITHUB_ENV
-
-    - if: ${{ inputs.create != 'true' }}
-      name: Restore Go modules
-      uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
-      with:
-        key: ${{ steps.cache-info.outputs.modules-key }}
-        path: |
-          ~/go/pkg/mod
-
-    - if: ${{ inputs.create != 'true' }}
-      name: Restore Go build cache
-      uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
-      with:
-        key: unused-key-${{ github.run_id }}
-        restore-keys: ${{ steps.cache-info.outputs.build-key }}-
-        path: |
-          ~/.cache/go-build
-          ~/Library/Caches/go-build
-          ~/AppData/Local/go-build
-
-    - if: ${{ inputs.create != 'true' && inputs.lint-cache == 'true' }}
-      name: Restore golangci-lint cache
-      uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
-      with:
-        key: unused-key-${{ github.run_id }}
-        restore-keys: ${{ steps.cache-info.outputs.lint-key }}-
-        path: ${{ env.GOLANGCI_LINT_CACHE }}
-
-    - name: Set mtimes
-      shell: bash
-      run: |
-        find . -type f ! -path ./.git/\*\* | go run github.com/slsyy/mtimehash/cmd/mtimehash@v1.0.0 || true
-        find . -type d ! -path ./.git/\*\* -exec touch -d '1970-01-01T00:00:01Z' {} + || true
-
-    # All steps below are only run if the cache is being created.
-
-    - if: ${{ inputs.create == 'true' }}
-      shell: bash
-      run: npm ci
-
-    - if: ${{ inputs.create == 'true' }}
-      shell: bash
-      run: |
-        go mod download
-        cd _tools
-        go mod download
-
-    - if: ${{ inputs.create == 'true' }}
-      shell: bash
-      run: npx hereby build
-
-    - if: ${{ inputs.create == 'true' }}
-      shell: bash
-      id: setup-go-test
-      run: npx hereby test
-
-    - if: ${{ failure() && inputs.create == 'true' && steps.setup-go-test.conclusion == 'failure' }}
-      shell: bash
-      run: git diff --diff-filter=AM --no-index ./testdata/baselines/reference ./testdata/baselines/local
-
-    - if: ${{ inputs.create == 'true' }}
-      shell: bash
-      run: npx hereby test --coverage
-
-    - if: ${{ inputs.create == 'true' }}
-      shell: bash
-      run: npx hereby lint
-
-    - if: ${{ inputs.create == 'true' }}
-      shell: bash
-      run: npx hereby lint --noembed
-
-    - if: ${{ inputs.create == 'true' }}
-      shell: bash
-      run: npx dprint check
-
-    - if: ${{ inputs.create == 'true' }}
-      name: Save Go modules
-      uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
-      with:
-        key: ${{ steps.cache-info.outputs.modules-key }}
-        path: |
-          ~/go/pkg/mod
-
-    - if: ${{ inputs.create == 'true' }}
-      name: Save Go build cache
-      uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
-      with:
-        key: ${{ steps.cache-info.outputs.build-key }}-${{ github.run_id }}
-        path: |
-          ~/.cache/go-build
-          ~/Library/Caches/go-build
-          ~/AppData/Local/go-build
-
-    - if: ${{ inputs.create == 'true' }}
-      name: Save golangci-lint cache
-      uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
-      with:
-        key: ${{ steps.cache-info.outputs.lint-key }}-${{ github.run_id }}
-        path: ${{ env.GOLANGCI_LINT_CACHE }}

.github/workflows/ci.yml

@@ -176,7 +176,7 @@ jobs:
 
       - run: git add .
 
-      - uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3
+      - uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
         if: ${{ always() && matrix.config.coverage && github.event_name != 'merge_group' }}
         with:
           use_oidc: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork) }}
@@ -234,8 +234,6 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
       - uses: ./.github/actions/setup-go
-        with:
-          lint-cache: 'true'
 
       # Avoid duplicate PR annotations.
       - if: ${{ ! matrix.config.main }}
@@ -282,8 +280,7 @@ jobs:
 
       - run: npx hereby generate
       - run: npx hereby generate:enums
-      - run: npm run -w @typescript/api generate:sync
-      - run: npm run -w @typescript/ast generate:factory
+      - run: npx hereby generate:ast
 
       - run: node --experimental-strip-types ./internal/lsp/lsproto/_generate/fetchModel.mts
       - run: node --experimental-strip-types ./internal/lsp/lsproto/_generate/generate.mts
@@ -349,10 +346,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
       - uses: ./.github/actions/setup-go
 
+      - run: npm ci
+
       - run: go -C ./_tools run ./cmd/checkmodpaths $PWD
 
+      - run: npx hereby check:scripts
+
   required:
     runs-on: ubuntu-latest
     if: ${{ always() }}

.github/workflows/codeql.yml

@@ -48,7 +48,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@38697555549f1db7851b81482ff19f1fa5c4fedc # v4.34.1
+        uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
         with:
           config-file: ./.github/codeql/codeql-configuration.yml
         # Override language selection by uncommenting this and choosing your languages
@@ -58,7 +58,7 @@ jobs:
       # Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below).
       - name: Autobuild
-        uses: github/codeql-action/autobuild@38697555549f1db7851b81482ff19f1fa5c4fedc # v4.34.1
+        uses: github/codeql-action/autobuild@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -72,4 +72,4 @@ jobs:
       #     make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@38697555549f1db7851b81482ff19f1fa5c4fedc # v4.34.1
+        uses: github/codeql-action/analyze@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1

.github/workflows/copilot-setup-steps.yml

@@ -29,8 +29,6 @@ jobs:
         with:
           node-version: '>=22.16.0'
       - uses: ./.github/actions/setup-go
-        with:
-          lint-cache: 'true'
       - run: npm i -g @playwright/mcp@0.0.28
       - run: go install golang.org/x/tools/gopls@latest
       - run: npm ci

.github/workflows/create-cache.yml

@@ -314,9 +314,11 @@ const enumDefs = [
     { name: "SignatureKind", goPrefix: "SignatureKind", goFile: "internal/checker/types.go", outDir: "_packages/api/src/enums" },
     { name: "ElementFlags", goPrefix: "ElementFlags", goFile: "internal/checker/types.go", outDir: "_packages/api/src/enums" },
     { name: "TypePredicateKind", goPrefix: "TypePredicateKind", goFile: "internal/checker/types.go", outDir: "_packages/api/src/enums" },
+    { name: "DiagnosticCategory", goPrefix: "Category", goFile: "internal/diagnostics/diagnostics.go", outDir: "_packages/api/src/enums" },
     // @typescript/ast enums
-    { name: "SyntaxKind", goPrefix: "Kind", goFile: "internal/ast/kind.go", outDir: "_packages/ast/src/enums" },
+    { name: "SyntaxKind", goPrefix: "Kind", goFile: "internal/ast/kind_generated.go", outDir: "_packages/ast/src/enums" },
     { name: "NodeFlags", goPrefix: "NodeFlags", goFile: "internal/ast/nodeflags.go", outDir: "_packages/ast/src/enums" },
+    { name: "OuterExpressionKinds", goPrefix: "OEK", goFile: "internal/ast/utilities.go", outDir: "_packages/ast/src/enums" },
     { name: "ModifierFlags", goPrefix: "ModifierFlags", goFile: "internal/ast/modifierflags.go", outDir: "_packages/ast/src/enums" },
     { name: "TokenFlags", goPrefix: "TokenFlags", goFile: "internal/ast/tokenflags.go", outDir: "_packages/ast/src/enums", constEnum: true },
 ];
@@ -435,17 +437,7 @@ function topoSortMembers(members) {
  * @returns {string}
  */
 function renderEnumTS(def, members) {
-    const header = [
-        "//",
-        "// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!",
-        "// !!! THIS FILE IS AUTO-GENERATED — DO NOT EDIT !!!",
-        "// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!",
-        "//",
-        `// Source: ${def.goFile}`,
-        "// Regenerate: npx hereby generate:enums",
-        "//",
-        "",
-    ].join("\n");
+    const header = `// Code generated by Herebyfile.mjs generate:enums from ${def.goFile}. DO NOT EDIT.\n\n`;
 
     const constKeyword = def.constEnum ? "const " : "";
     const lines = members.map(m => `    ${m.name} = ${m.value},`);
@@ -508,6 +500,12 @@ export const generateEnums = task({
     run: runGenerateEnums,
 });
 
+export const generateAST = task({
+    name: "generate:ast",
+    description: "Generates AST and encoder files from ast.json.",
+    run: () => $`node --experimental-strip-types --no-warnings ./_scripts/generate.ts`,
+});
+
 const coverageDir = path.join(__dirname, "coverage");
 
 const ensureCoverageDirExists = memoize(() => {
@@ -856,6 +854,23 @@ export const checkFormat = task({
     },
 });
 
+const scriptTsconfigs = [
+    "./_scripts/tsconfig.json",
+    "./internal/fourslash/_scripts/tsconfig.json",
+    "./internal/lsp/lsproto/_generate/tsconfig.json",
+];
+
+export const checkScripts = task({
+    name: "check:scripts",
+    description: "Type-checks TypeScript scripts.",
+    run: async () => {
+        for (const tsconfig of scriptTsconfigs) {
+            console.log(`Type-checking ${tsconfig}`);
+            await $`tsc -p ${tsconfig}`;
+        }
+    },
+});
+
 /**
  * @param {string} localBaseline Path to the local copy of the baselines
  * @param {string} refBaseline Path to the reference copy of the baselines

Herebyfile.mjs

@@ -379,3 +379,24 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
 ---------------------------------------------------------
 
+---------------------------------------------------------
+
+github.com/mackerelio/go-osstat v0.2.7 - Apache-2.0
+
+
+Copyright 2017-2019 Hatena Co., Ltd.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+---------------------------------------------------------
+

NOTICE.txt

@@ -34,12 +34,12 @@ This is still a work in progress and is not yet at full feature parity with Type
 | Type checking | done | Same errors, locations, and messages as TS 6.0. Types printback in errors may display differently. |
 | JavaScript-specific inference and JSDoc | in progress | Mostly complete, but intentionally lacking some features. Declaration emit not complete. |
 | JSX | done | - |
-| Declaration emit | in progress | Most common features are in place, but some edge cases and feature flags are still unhandled. |
-| Emit (JS output) | in progress | `target: esnext` well-supported, other targets may have gaps. |
+| Declaration emit | in progress | Done for TypeScript files. Not yet complete for JavaScript files. |
+| Emit (JS output) | done | - |
 | Watch mode | prototype | Watches files and rebuilds, but no incremental rechecking. Not optimized. |
 | Build mode / project references | done | - |
 | Incremental build | done | - |
-| Language service (LSP) | in progress | Most functionality. More features coming soon. |
+| Language service (LSP) | in progress | Nearly all features implemented. |
 | API | not ready | - |
 
 Definitions: