Skip to content

Commit 515d036

Browse files
CopilotDanielRosenwasserRyanCavanaugh
authored
Accept direct JSX runtime factory call baseline (#3591)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com> Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com> Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>
1 parent 5155de3 commit 515d036

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

testdata/baselines/reference/submoduleTriaged/compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsx,module=commonjs,moduledetection=legacy).js.diff renamed to testdata/baselines/reference/submoduleAccepted/compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsx,module=commonjs,moduledetection=legacy).js.diff

File renamed without changes.

testdata/submoduleAccepted.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,9 @@ conformance/typesWithSpecializedCallSignatures.types.diff
192192
conformance/typesWithSpecializedConstructSignatures.types.diff
193193
conformance/unionTypeReduction2.types.diff
194194

195+
## Generated JSX factory calls for script files in react-jsx and moduleDetection=legacy are arbitrary ##
196+
compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsx,module=commonjs,moduledetection=legacy).js.diff
197+
195198
## _jsxFileName path ##
196199
compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=commonjs,moduledetection=auto).js.diff
197200
compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=commonjs,moduledetection=legacy).js.diff

testdata/submoduleTriaged.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,6 @@ conformance/nodeModulesAllowJsExportAssignment(module=node18).js.diff
201201
conformance/nodeModulesAllowJsExportAssignment(module=node20).js.diff
202202
conformance/nodeModulesAllowJsExportAssignment(module=nodenext).js.diff
203203

204-
# JSX factory call changed from indirect (0, _a.jsx)(...) to direct _jsx(...) call
205-
## https://github.com/microsoft/typescript-go/issues/3553
206-
compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsx,module=commonjs,moduledetection=legacy).js.diff
207-
208204
# @overload handling changes in JS declaration emit
209205
## https://github.com/microsoft/typescript-go/issues/3555
210206
compiler/jsFileAlternativeUseOfOverloadTag.js.diff

0 commit comments

Comments
 (0)