Handle urls in import path by making vfs not panic on Url paths (#2685)

Author: sheetalkamat

internal/project/untitled_test.go

@@ -159,3 +159,26 @@ x++;`
 	// We expect to find 4 references
 	assert.Assert(t, len(refs) == 4, "Expected 4 references, got %d", len(refs))
 }
+
+func TestImportsInUntitled(t *testing.T) {
+	t.Parallel()
+	if !bundled.Embedded {
+		t.Skip("bundled files are not embedded")
+	}
+
+	files := map[string]any{
+		// Make sure typings directory exists so it would actually try to fetch typings from this location
+		projecttestutil.TestTypingsLocation + "/node_modules/@types/somelib/index.d.ts": `export const x: number;`,
+	}
+	session, _ := projecttestutil.Setup(files)
+	content := `import "https://deno.land/std@0.208.0/path/mod.ts"
+		import  "./relative"
+`
+	uri1 := lsproto.DocumentUri("untitled:Untitled-1")
+	session.DidOpenFile(context.Background(), uri1, 1, content, lsproto.LanguageKindTypeScript)
+
+	// 2) Wait for ATA/background tasks to finish, then get a language service for the first file
+	session.WaitForBackgroundTasks()
+	_, err := session.GetLanguageService(context.Background(), uri1)
+	assert.NilError(t, err)
+}

internal/vfs/internal/internal.go

@@ -19,8 +19,10 @@ type Common struct {
 
 func RootLength(p string) int {
 	l := tspath.GetEncodedRootLength(p)
-	if l <= 0 {
+	if l == 0 {
 		panic(fmt.Sprintf("vfs: path %q is not absolute", p))
+	} else if l < 0 {
+		return ^l
 	}
 	return l
 }

internal/vfs/iovfs/iofs.go

@@ -112,6 +112,9 @@ func From(fsys fs.FS, useCaseSensitiveFileNames bool) FsWithSys {
 				p := tspath.RemoveTrailingDirectorySeparator(root)
 				sub, err := fs.Sub(fsys, p)
 				if err != nil {
+					if tspath.IsUrl(root) {
+						return nil
+					}
 					panic(fmt.Sprintf("vfs: failed to create sub file system for %q: %v", p, err))
 				}
 				return sub

testdata/baselines/reference/compiler/importUrl.js

@@ -0,0 +1,10 @@
+//// [tests/cases/compiler/importUrl.ts] ////
+
+//// [index.ts]
+import "https://deno.land/std@0.208.0/path/mod.ts"
+
+
+//// [index.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("https://deno.land/std@0.208.0/path/mod.ts");

testdata/baselines/reference/compiler/importUrl.symbols

@@ -0,0 +1,6 @@
+//// [tests/cases/compiler/importUrl.ts] ////
+
+=== /src/index.ts ===
+
+import "https://deno.land/std@0.208.0/path/mod.ts"
+

testdata/baselines/reference/compiler/importUrl.trace.json

@@ -0,0 +1,7 @@
+======== Resolving module 'https://deno.land/std@0.208.0/path/mod.ts' from '/src/index.ts'. ========
+Module resolution kind is not specified, using 'Bundler'.
+Resolving in CJS mode with conditions 'require', 'types'.
+File '/src/package.json' does not exist.
+File '/package.json' does not exist.
+Skipping module 'https://deno.land/std@0.208.0/path/mod.ts' that looks like an absolute URI, target file types: TypeScript, JavaScript, Declaration, JSON.
+======== Module name 'https://deno.land/std@0.208.0/path/mod.ts' was not resolved. ========

testdata/baselines/reference/compiler/importUrl.types

@@ -0,0 +1,6 @@
+//// [tests/cases/compiler/importUrl.ts] ////
+
+=== /src/index.ts ===
+
+import "https://deno.land/std@0.208.0/path/mod.ts"
+

testdata/baselines/reference/compiler/importUrlNodeModulesExist.js

@@ -0,0 +1,17 @@
+//// [tests/cases/compiler/importUrlNodeModulesExist.ts] ////
+
+//// [package.json]
+{ "name": "foo", "version": "1.0.0" }
+
+//// [index.d.ts]
+export declare function useFoo(): string;
+
+//// [index.ts]
+import "https://deno.land/std@0.208.0/path/mod.ts"
+
+
+
+//// [index.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("https://deno.land/std@0.208.0/path/mod.ts");

testdata/baselines/reference/compiler/importUrlNodeModulesExist.symbols

@@ -0,0 +1,11 @@
+//// [tests/cases/compiler/importUrlNodeModulesExist.ts] ////
+
+=== /node_modules/foo/index.d.ts ===
+export declare function useFoo(): string;
+>useFoo : Symbol(useFoo, Decl(index.d.ts, 0, 0))
+
+=== /src/index.ts ===
+
+import "https://deno.land/std@0.208.0/path/mod.ts"
+
+

testdata/baselines/reference/compiler/importUrlNodeModulesExist.trace.json

@@ -0,0 +1,7 @@
+======== Resolving module 'https://deno.land/std@0.208.0/path/mod.ts' from '/src/index.ts'. ========
+Module resolution kind is not specified, using 'Bundler'.
+Resolving in CJS mode with conditions 'require', 'types'.
+File '/src/package.json' does not exist.
+File '/package.json' does not exist.
+Skipping module 'https://deno.land/std@0.208.0/path/mod.ts' that looks like an absolute URI, target file types: TypeScript, JavaScript, Declaration, JSON.
+======== Module name 'https://deno.land/std@0.208.0/path/mod.ts' was not resolved. ========