Skip to content

Commit 78694bb

Browse files
Copilotjakebailey
andauthored
Ship API enums without the const modifier (#4243)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
1 parent 98834ec commit 78694bb

8 files changed

Lines changed: 9 additions & 11 deletions

Herebyfile.mjs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,6 @@ export const generate = task({
304304
* goPrefix: string;
305305
* goFile: string;
306306
* outDir: string;
307-
* constEnum?: boolean;
308307
* }} EnumDef
309308
*/
310309

@@ -322,7 +321,7 @@ const enumDefs = [
322321
{ name: "NodeFlags", goPrefix: "NodeFlags", goFile: "internal/ast/nodeflags.go", outDir: "_packages/native-preview/src/enums" },
323322
{ name: "OuterExpressionKinds", goPrefix: "OEK", goFile: "internal/ast/utilities.go", outDir: "_packages/native-preview/src/enums" },
324323
{ name: "ModifierFlags", goPrefix: "ModifierFlags", goFile: "internal/ast/modifierflags.go", outDir: "_packages/native-preview/src/enums" },
325-
{ name: "TokenFlags", goPrefix: "TokenFlags", goFile: "internal/ast/tokenflags.go", outDir: "_packages/native-preview/src/enums", constEnum: true },
324+
{ name: "TokenFlags", goPrefix: "TokenFlags", goFile: "internal/ast/tokenflags.go", outDir: "_packages/native-preview/src/enums" },
326325
{ name: "NodeBuilderFlags", goPrefix: "Flags", goFile: "internal/nodebuilder/types.go", outDir: "_packages/native-preview/src/enums" },
327326
];
328327

@@ -442,9 +441,8 @@ function topoSortMembers(members) {
442441
function renderEnumTS(def, members) {
443442
const header = `// Code generated by Herebyfile.mjs generate:enums from ${def.goFile}. DO NOT EDIT.\n\n`;
444443

445-
const constKeyword = def.constEnum ? "const " : "";
446444
const lines = members.map(m => ` ${m.name} = ${m.value},`);
447-
return `${header}export ${constKeyword}enum ${def.name} {\n${lines.join("\n")}\n}\n`;
445+
return `${header}export enum ${def.name} {\n${lines.join("\n")}\n}\n`;
448446
}
449447

450448
async function runGenerateEnums() {

_packages/native-preview/src/enums/characterCodes.enum.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum CharacterCodes {
1+
export enum CharacterCodes {
22
EOF = -1,
33
nullCharacter = 0,
44
maxAsciiCharacter = 0x7F,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum CommentDirectiveType {
1+
export enum CommentDirectiveType {
22
ExpectError = 0,
33
Ignore = 1,
44
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum LanguageVariant {
1+
export enum LanguageVariant {
22
Standard = 0,
33
JSX = 1,
44
}

_packages/native-preview/src/enums/regularExpressionFlags.enum.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum RegularExpressionFlags {
1+
export enum RegularExpressionFlags {
22
None = 0,
33
HasIndices = 1 << 0,
44
Global = 1 << 1,

_packages/native-preview/src/enums/scriptKind.enum.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum ScriptKind {
1+
export enum ScriptKind {
22
Unknown = 0,
33
JS = 1,
44
JSX = 2,

_packages/native-preview/src/enums/scriptTarget.enum.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum ScriptTarget {
1+
export enum ScriptTarget {
22
ES2015 = 2,
33
ES2016 = 3,
44
ES2017 = 4,

_packages/native-preview/src/enums/tokenFlags.enum.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Code generated by Herebyfile.mjs generate:enums from internal/ast/tokenflags.go. DO NOT EDIT.
22

3-
export const enum TokenFlags {
3+
export enum TokenFlags {
44
None = 0,
55
PrecedingLineBreak = 1 << 0,
66
PrecedingJSDocComment = 1 << 1,

0 commit comments

Comments
 (0)