Merge branch 'main' into guyllian.gomez/yarn-pnp

Author: GGomez99

.dprint.jsonc

@@ -51,14 +51,15 @@
         "internal/lsp/lsproto/_generate/*.json",
         "internal/lsp/lsproto/_generate/metaModelSchema.mts",
         // Needs to be LF to have a working shebang.
-        "_packages/native-preview/bin/tsgo.js"
+        "_packages/native-preview/bin/tsgo.js",
+        "_packages/native-preview/vendor/**"
     ],
     // Note: if adding new languages, make sure settings.template.json is updated too.
     // Also, if updating typescript, update the one in package.json.
     "plugins": [
         "https://plugins.dprint.dev/typescript-0.95.15.wasm",
-        "https://plugins.dprint.dev/json-0.21.1.wasm",
+        "https://plugins.dprint.dev/json-0.21.3.wasm",
         "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.6.0.wasm",
-        "https://plugins.dprint.dev/jakebailey/gofumpt-v0.0.7.wasm"
+        "https://plugins.dprint.dev/jakebailey/gofumpt-v0.0.8.wasm"
     ]
 }

.github/workflows/ci.yml

@@ -31,7 +31,7 @@ jobs:
           swap-storage: false
           dotnet: false
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
       - uses: ./.github/actions/setup-go
 
       # Avoid duplicate PR annotations.
@@ -51,7 +51,7 @@ jobs:
     runs-on: TypeScript-1ES-GitHub-XL-2
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
         with:
           node-version: 'lts/*'
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
@@ -73,7 +73,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
 
       - run: npm ci
 
@@ -140,7 +140,7 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           submodules: ${{ !matrix.config.no-submodules }}
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
         with:
           node-version: 'lts/*'
       - uses: ./.github/actions/setup-go
@@ -232,7 +232,7 @@ jobs:
           swap-storage: false
           dotnet: false
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
       - uses: ./.github/actions/setup-go
 
       # Avoid duplicate PR annotations.
@@ -249,10 +249,10 @@ jobs:
       - run: npx hereby lint
 
   format:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-slim
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
       - uses: ./.github/actions/setup-go
 
       - run: npm ci
@@ -271,7 +271,7 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           submodules: true
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
         with:
           node-version: '>=22.16.0'
       - uses: ./.github/actions/setup-go
@@ -301,7 +301,7 @@ jobs:
       - run: git diff --staged --exit-code --stat
 
   tidy:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-slim
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - uses: ./.github/actions/setup-go
@@ -321,7 +321,7 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           submodules: true
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
       - uses: ./.github/actions/setup-go
 
       # Avoid duplicate PR annotations.
@@ -346,7 +346,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
       - uses: ./.github/actions/setup-go
 
       - run: npm ci
@@ -356,7 +356,7 @@ jobs:
       - run: npx hereby check:scripts
 
   required:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-slim
     if: ${{ always() }}
     needs:
       - build

.github/workflows/codeql.yml

@@ -48,7 +48,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
+        uses: github/codeql-action/init@95e58e9a2cdfd71adc6e0353d5c52f41a045d225 # v4.35.2
         with:
           config-file: ./.github/codeql/codeql-configuration.yml
         # Override language selection by uncommenting this and choosing your languages
@@ -58,7 +58,7 @@ jobs:
       # Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below).
       - name: Autobuild
-        uses: github/codeql-action/autobuild@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
+        uses: github/codeql-action/autobuild@95e58e9a2cdfd71adc6e0353d5c52f41a045d225 # v4.35.2
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -72,4 +72,4 @@ jobs:
       #     make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
+        uses: github/codeql-action/analyze@95e58e9a2cdfd71adc6e0353d5c52f41a045d225 # v4.35.2

.github/workflows/copilot-setup-steps.yml

@@ -25,7 +25,7 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           submodules: true
-      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
         with:
           node-version: '>=22.16.0'
       - uses: ./.github/actions/setup-go

.gitignore

@@ -194,6 +194,7 @@ custom-gcl.hash
 .idea
 
 !testdata/submoduleAccepted.txt
+!testdata/submoduleTriaged.txt
 
 !NOTICE.txt
 

.golangci.yml

@@ -65,6 +65,10 @@ linters:
       customlint:
         type: module
 
+    modernize:
+      disable:
+        - slicesbackward # https://github.com/golang/go/issues/78829
+
     depguard:
       rules:
         main:

.vscode/launch.template.json

@@ -61,6 +61,29 @@
                 "-testDir",
                 "path_to_project_dir"
             ]
+        },
+        {
+            "name": "Launch tsgo CLI",
+            "type": "go",
+            "request": "launch",
+            "mode": "debug",
+            "program": "${workspaceFolder}/cmd/tsgo",
+            "cwd": "${workspaceFolder}",
+            "args": "${input:tsgoArgs}"
+        },
+        {
+            "name": "Attach to Go process",
+            "type": "go",
+            "request": "attach",
+            "mode": "local",
+            "processId": "${command:pickGoProcess}"
+        }
+    ],
+    "inputs": [
+        {
+            "id": "tsgoArgs",
+            "type": "promptString",
+            "description": "Enter arguments for tsgo"
         }
     ]
 }

CHANGES.md

@@ -28,6 +28,17 @@ function f() {}
 f.called = false;
 ```
 
+## Declaration Emit
+
+We've fundamentally rewritten core parts of the declaration emit *and* JavaScript parsing components.
+As a result, declaration (`.d.ts`) emit based on `.js` input files has substantially changed behavior.
+While it's still expected that supported tags (see below) are emitted with correct semantics in Corsa, it's a non-goal to exactly match Strada's output.
+
+This also has effects on how `.d.ts` is emitted in the presence of errors, which tends to be more common in `.js` and JSDoc scenarios.
+Declaration file generation isn't well-defined in the presence of errors (including those suppressed with `ts-ignore`/`ts-expect-error`), and you can expect Corsa and Strada to be quite different depending on the situation.
+
+However, if you see **_incorrect_** `.d.ts` output from a `.js` file, **please file an issue**.
+
 ## JSDoc Tags and Types
 
 | Name                       | Example | Substitute  | Note |
@@ -123,18 +134,6 @@ function f(x) {
 f(); // Still allowed
 ```
 
-#### Strada's JS-specific rules for inferring type arguments no longer apply in Corsa.
-
-Inferred type arguments may change. For example:
-
-```js
-/** @type {any} */
-var x = { a: 1, b: 2 };
-var entries = Object.entries(x);
-```
-
-In Strada, `entries: Array<[string, any]>`. In Corsa it has type `Array<[string, unknown]>`, the same as in TypeScript.
-
 #### Values are no longer resolved as types in JSDoc type positions.
 
 ```js
@@ -346,3 +345,7 @@ exports.foo = exports.bar = void 0;
 exports.foo = 123  // Exported type is `123`
 exports.bar = "abc"  // Exported type is `"abc"`
 ```
+
+#### Mixing module.exports assignments
+
+Corsa does not permit CommonJS modules to mix assignments to the full `module.exports` with assignments to `module.exports.xxx` properties. A CommonJS module must either contain an assignment to `module.exports` or a series of assignments to `module.exports.xxx` properties, but not both.