Preserve the original parameter-list range when injecting reparsed this parameter (#2976)

Author: Andarist

internal/fourslash/tests/documentHighlightJSDocThisFunctionExpressionNoCrash1_test.go

@@ -0,0 +1,19 @@
+package fourslash_test
+
+import (
+	"testing"
+
+	"github.com/microsoft/typescript-go/internal/fourslash"
+	"github.com/microsoft/typescript-go/internal/testutil"
+)
+
+func TestDocumentHighlightJSDocThisFunctionExpressionParameter(t *testing.T) {
+	t.Parallel()
+	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
+	const content = `// @allowJs: true
+// @Filename: /a.js
+/**@this{A}*/x=function(/*m*/a){};`
+	f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
+	defer done()
+	f.VerifyBaselineDocumentHighlights(t, nil /*preferences*/, "m")
+}

internal/parser/reparser.go

@@ -470,7 +470,7 @@ func (p *Parser) reparseHosted(tag *ast.Node, parent *ast.Node, jsDoc *ast.Node)
 					newParams[i+1] = param
 				}
 
-				fun.FunctionLikeData().Parameters = p.newNodeList(thisParam.Loc, newParams)
+				fun.FunctionLikeData().Parameters = p.newNodeList(fun.ParameterList().Loc, newParams)
 				p.finishMutatedNode(fun)
 			}
 		}

testdata/baselines/reference/fourslash/documentHighlights/documentHighlightJSDocThisFunctionExpressionParameter.baseline.jsonc

@@ -0,0 +1,3 @@
+// === documentHighlights ===
+// === /a.js ===
+// /**@this{A}*/x=function(/*HIGHLIGHTS*/[|a|]){};