Port code to issue JS specific error for promises (#3653)

Author: ahejlsberg

internal/checker/checker.go

@@ -9559,6 +9559,10 @@ func (c *Checker) getArgumentArityError(node *ast.Node, signatures []*Signature,
 		parameterRange = strconv.Itoa(minCount)
 	}
 	isVoidPromiseError := !hasRestParameter && parameterRange == "1" && len(args) == 0 && c.isPromiseResolveArityError(node)
+	errorNode := getErrorNodeForCallNode(node)
+	if isVoidPromiseError && ast.IsInJSFile(node) {
+		return NewDiagnosticForNode(errorNode, diagnostics.Expected_1_argument_but_got_0_new_Promise_needs_a_JSDoc_hint_to_produce_a_resolve_that_can_be_called_without_arguments)
+	}
 	var message *diagnostics.Message
 	switch {
 	case ast.IsDecorator(node):
@@ -9574,7 +9578,6 @@ func (c *Checker) getArgumentArityError(node *ast.Node, signatures []*Signature,
 	default:
 		message = diagnostics.Expected_0_arguments_but_got_1
 	}
-	errorNode := getErrorNodeForCallNode(node)
 	switch {
 	case minCount < len(args) && len(args) < maxCount:
 		// between min and max, but with no matching overload

testdata/baselines/reference/compiler/jsPromiseNeedsJSDocHint.errors.txt

@@ -0,0 +1,8 @@
+main.js(1,26): error TS2810: Expected 1 argument, but got 0. 'new Promise()' needs a JSDoc hint to produce a 'resolve' that can be called without arguments.
+
+
+==== main.js (1 errors) ====
+    new Promise((resolve) => resolve());
+                             ~~~~~~~
+!!! error TS2810: Expected 1 argument, but got 0. 'new Promise()' needs a JSDoc hint to produce a 'resolve' that can be called without arguments.
+    

testdata/baselines/reference/compiler/jsPromiseNeedsJSDocHint.symbols

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/jsPromiseNeedsJSDocHint.ts] ////
+
+=== main.js ===
+new Promise((resolve) => resolve());
+>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2018.promise.d.ts, --, --))
+>resolve : Symbol(resolve, Decl(main.js, 0, 13))
+>resolve : Symbol(resolve, Decl(main.js, 0, 13))
+

testdata/baselines/reference/compiler/jsPromiseNeedsJSDocHint.types

@@ -0,0 +1,11 @@
+//// [tests/cases/compiler/jsPromiseNeedsJSDocHint.ts] ////
+
+=== main.js ===
+new Promise((resolve) => resolve());
+>new Promise((resolve) => resolve()) : Promise<any>
+>Promise : PromiseConstructor
+>(resolve) => resolve() : (resolve: (value: any) => void) => void
+>resolve : (value: any) => void
+>resolve() : void
+>resolve : (value: any) => void
+

testdata/tests/cases/compiler/jsPromiseNeedsJSDocHint.ts

@@ -0,0 +1,7 @@
+// @checkJs: true
+// @noEmit: true
+
+// https://github.com/microsoft/typescript-go/issues/3641
+
+// @filename: main.js
+new Promise((resolve) => resolve());