Fix unknown extension crash in completions#2679
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in completions when encountering files with unrecognized extensions (e.g., .ruhroh) that are defined as ambient modules.
Changes:
- Modified
kindModifiersFromExtensionto gracefully handle unknown file extensions by returningScriptElementKindModifierNoneinstead of panicking - Added a regression test to ensure completions work correctly with unknown extensions defined in ambient module declarations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/ls/string_completions.go | Changed default case in kindModifiersFromExtension to return ScriptElementKindModifierNone instead of panicking, allowing the language server to handle unknown file extensions gracefully |
| internal/fourslash/tests/completionsPathUnknownExtension_test.go | Added a comprehensive test that reproduces the crash scenario from issue #2669 with a .ruhroh extension and verifies completions work without crashing |
DanielRosenwasser
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2669.
I updated the path completions code to add extensions in more cases compared to Strada (#2610), so now we may include unsupported extensions in path completions, but we shouldn't crash on them.