Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions internal/fourslash/tests/completionsPathUnknownExtension_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package fourslash_test

import (
"testing"

"github.com/microsoft/typescript-go/internal/fourslash"
. "github.com/microsoft/typescript-go/internal/fourslash/tests/util"
"github.com/microsoft/typescript-go/internal/testutil"
)

func TestCompletionsPathUnknownExtension(t *testing.T) {
t.Parallel()
defer testutil.RecoverAndFail(t, "Panic on fourslash test")

const content = `// @filename: src/some-file.ruhroh
/* This is just a test file that needs to exist. */

// @filename: package.json
{
"imports": {
"#/*": "./src/*"
}
}

// @filename: src/globals.d.ts
declare module "*.ruhroh";

// @filename: src/a.mts
import "#//*$*/"

// @filename: tsconfig.json
{
"compilerOptions": {
"module": "preserve",
"moduleResolution": "bundler",
"rootDir": "src"
},
"include": ["src"]
}`

f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
defer done()
f.VerifyCompletions(t, "$", &fourslash.CompletionsExpectedList{
IsIncomplete: false,
ItemDefaults: &fourslash.CompletionsExpectedItemDefaults{
CommitCharacters: &[]string{},
EditRange: Ignored,
},
Items: &fourslash.CompletionsExpectedItems{
Includes: []fourslash.CompletionsExpectedItem{},
Comment thread
gabritto marked this conversation as resolved.
Outdated
},
})
}
4 changes: 1 addition & 3 deletions internal/ls/string_completions.go
Original file line number Diff line number Diff line change
Expand Up @@ -1939,10 +1939,8 @@ func kindModifiersFromExtension(extension string) lsutil.ScriptElementKindModifi
return lsutil.ScriptElementKindModifierCts
case tspath.ExtensionTsBuildInfo:
panic(fmt.Sprintf("Extension %v is unsupported.", tspath.ExtensionTsBuildInfo))
case "":
return lsutil.ScriptElementKindModifierNone
default:
panic(fmt.Sprintf("Unexpected extension: %v", extension))
return lsutil.ScriptElementKindModifierNone
}
}

Expand Down
Loading