Fix race when copying lazy computed values for updateProgram#2702
Merged
jakebailey merged 3 commits intomainfrom Feb 10, 2026
Merged
Fix race when copying lazy computed values for updateProgram#2702jakebailey merged 3 commits intomainfrom
jakebailey merged 3 commits intomainfrom
Conversation
jakebailey
reviewed
Feb 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a reported data race (#2275) in the TypeScript-go compiler’s Program cloning path (updateProgram/UpdateProgram) by making certain lazily computed caches safe to copy across program updates.
Changes:
- Introduced a generic
lazyValue[T]helper to safely manage lazily computed cached values with a “try-get-if-initialized” path. - Updated
Programto storeunresolvedImportsandknownSymlinksusinglazyValue, and adjustedGetUnresolvedImports/GetSymlinkCacheaccordingly. - Modified
UpdateProgramto copy only fully-initialized cached values for these fields, avoiding concurrent reads of partially initialized state.
jakebailey
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2275