Fix "Disable" not reactivating built-in TypeScript extension#3652
Merged
andrewbranch merged 2 commits intomainfrom Apr 29, 2026
Merged
Fix "Disable" not reactivating built-in TypeScript extension#3652andrewbranch merged 2 commits intomainfrom
andrewbranch merged 2 commits intomainfrom
Conversation
…ilt-in TS extension (#3651) Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/0310cf71-98eb-4c95-b7d4-142bb7eeb39f Co-authored-by: andrewbranch <3277153+andrewbranch@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
andrewbranch
April 28, 2026 23:00
View session
Member
|
@copilot add a command palette menu item for this in package.json. It should say "TypeScript Native Preview: Select TypeScript Version..." |
Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/e87d0f9b-1211-48d2-be6b-a7dec199b50a Co-authored-by: andrewbranch <3277153+andrewbranch@users.noreply.github.com>
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a VS Code command ID collision between the native preview extension and the built-in TypeScript extension that could prevent the built-in extension from reactivating after disabling native preview.
Changes:
- Renames the version selection command to
typescript.native-preview.selectVersionto avoid conflicting withtypescript.selectTypeScriptVersion. - Updates the native preview “server menu” quick pick to invoke the renamed command.
- Adds a contributed command so “TypeScript Native Preview: Select TypeScript Version...” appears in the command palette.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_extension/src/session.ts |
Renames the registered version picker command and updates the menu entry to use the new command ID. |
_extension/package.json |
Contributes the new command ID to VS Code so it shows up in the command palette (with proper enablement/category). |
DanielRosenwasser
approved these changes
Apr 28, 2026
andrewbranch
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3516 registered the command
typescript.selectTypeScriptVersion— the same ID used by the built-in TS extension in VS Code. On disable, the built-in extension'sconditionalRegistrationreacts to the config change immediately and tries to re-register its normal features including that command, but the native preview session is still alive (100ms debounce), sovscode.commands.registerCommandthrows, and the entire built-in extension reactivation fails silently.typescript.native-preview.selectVersionto avoid the collision