Fix flake in TestRegistryLifecycle pnpm-style symlink test#3685
Open
jakebailey wants to merge 1 commit intomainfrom
Open
Fix flake in TestRegistryLifecycle pnpm-style symlink test#3685jakebailey wants to merge 1 commit intomainfrom
jakebailey wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a flaky auto-import registry lifecycle test by ensuring assertions read cache stats from the same request-time snapshot that observed the file change, avoiding races with background auto-import warming that can advance the session snapshot.
Changes:
- Switch the pnpm-style symlink test to read
AutoImportRegistrycache stats from the snapshot provided bySession.WithLanguageServiceAndSnapshotinstead ofsession.Snapshot(). - Add the needed
internal/lsimport to type the callback parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this test flake: https://github.com/microsoft/typescript-go/actions/runs/25234356902/job/73997098962