Skip to content

Fix resolveNodeHandle to check not only child nodes but ancestor nodes #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jet2jet wants to merge 2 commits into from
+7 −1
Closed

Fix resolveNodeHandle to check not only child nodes but ancestor nodes #4033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dd088d
Fix resolveNodeHandle to check not only child nodes but ancestor nodes
jet2jet May 23, 2026
1d8cc89
Add pos check for found node
jet2jet May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/api/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1838,7 +1838,13 @@ func (s *Session) resolveNodeHandle(program *compiler.Program, handle Handle[ast
}

// Verify the kind and end match
if node.Kind != kind || node.End() != end {
if node.Kind != kind || node.Pos() != pos || node.End() != end {
// Try to find the exact node by walking ancestors
for parent := node.Parent; parent != nil && parent.Kind != ast.KindSourceFile; parent = parent.Parent {
if parent.Pos() == pos && parent.End() == end && parent.Kind == kind {
return parent, nil
}
}
// Try to find the exact node by walking children
var found *ast.Node
node.ForEachChild(func(child *ast.Node) bool {
Expand Down