Check this params when comparing pseudotype signatures to type signatures#4062
Open
weswigham wants to merge 5 commits into
Open
Check this params when comparing pseudotype signatures to type signatures#4062weswigham wants to merge 5 commits into
this params when comparing pseudotype signatures to type signatures#4062weswigham wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an isolated declarations mismatch where pseudo-type signature comparison ignored this parameters, causing incorrect fallback diagnostics for object methods using captured generics in this.
Changes:
- Adds
thisparameter-aware comparison for pseudo parameters against checker signatures. - Refactors duplicated parameter comparison logic into a shared helper.
- Adds a compiler regression test and baselines for the captured generic
thisparameter case.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/checker/pseudotypenodebuilder.go |
Adds shared pseudo/checker parameter equivalence logic with thisParameter handling. |
testdata/tests/cases/compiler/isolatedDeclarationsThisParameterWithCapturedGeneric.ts |
Adds regression coverage for the issue. |
testdata/baselines/reference/compiler/isolatedDeclarationsThisParameterWithCapturedGeneric.js |
Adds emitted JS and declaration baseline. |
testdata/baselines/reference/compiler/isolatedDeclarationsThisParameterWithCapturedGeneric.symbols |
Adds symbol baseline. |
testdata/baselines/reference/compiler/isolatedDeclarationsThisParameterWithCapturedGeneric.types |
Adds type baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4057