Skip to content

Move last diff in ID triaged category to accepted#4524

Merged
weswigham merged 1 commit into
microsoft:mainfrom
weswigham:move-last-error-to-accepted
Jul 2, 2026
Merged

Move last diff in ID triaged category to accepted#4524
weswigham merged 1 commit into
microsoft:mainfrom
weswigham:move-last-error-to-accepted

Conversation

@weswigham

Copy link
Copy Markdown
Member

The error corsa issues is just better, since it actually reports the issue inference failed with.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reclassifies the isolatedDeclarationsAddUndefined isolated-declarations error output change from “triaged (to be fixed)” to “accepted (intentional divergence)”, reflecting that Corsa’s diagnostic is preferable and should not be tracked as a to-fix diff.

Changes:

  • Removed compiler/isolatedDeclarationsAddUndefined.errors.txt.diff from submoduleTriaged.
  • Added compiler/isolatedDeclarationsAddUndefined.errors.txt.diff to submoduleAccepted with a short rationale comment.
  • Added the corresponding accepted baseline diff file under testdata/baselines/reference/submoduleAccepted/compiler/.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
testdata/submoduleTriaged.txt Removes the isolated-declarations diff from the “triaged” list.
testdata/submoduleAccepted.txt Adds the isolated-declarations diff to the “accepted” list with a rationale header.
testdata/baselines/reference/submoduleAccepted/compiler/isolatedDeclarationsAddUndefined.errors.txt.diff Introduces the accepted baseline diff capturing the improved diagnostic (TS9011 → TS9025 + caret location change).
Comments suppressed due to low confidence (1)

testdata/submoduleAccepted.txt:1442

  • The new accepted-diff header has a grammar issue ("error issued" reads awkwardly) and the trailing blank line appears to contain whitespace. Consider rewording the header for clarity and drop the trailing whitespace-only line.

# Better isolatedDeclarations error issued on cast initializer before required parameter
compiler/isolatedDeclarationsAddUndefined.errors.txt.diff

@weswigham weswigham added this pull request to the merge queue Jul 2, 2026
Merged via the queue into microsoft:main with commit 5e86caf Jul 2, 2026
21 checks passed
@weswigham weswigham deleted the move-last-error-to-accepted branch July 2, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants