Move last diff in ID triaged category to accepted#4524
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reclassifies the isolatedDeclarationsAddUndefined isolated-declarations error output change from “triaged (to be fixed)” to “accepted (intentional divergence)”, reflecting that Corsa’s diagnostic is preferable and should not be tracked as a to-fix diff.
Changes:
- Removed
compiler/isolatedDeclarationsAddUndefined.errors.txt.difffromsubmoduleTriaged. - Added
compiler/isolatedDeclarationsAddUndefined.errors.txt.difftosubmoduleAcceptedwith a short rationale comment. - Added the corresponding accepted baseline diff file under
testdata/baselines/reference/submoduleAccepted/compiler/.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testdata/submoduleTriaged.txt | Removes the isolated-declarations diff from the “triaged” list. |
| testdata/submoduleAccepted.txt | Adds the isolated-declarations diff to the “accepted” list with a rationale header. |
| testdata/baselines/reference/submoduleAccepted/compiler/isolatedDeclarationsAddUndefined.errors.txt.diff | Introduces the accepted baseline diff capturing the improved diagnostic (TS9011 → TS9025 + caret location change). |
Comments suppressed due to low confidence (1)
testdata/submoduleAccepted.txt:1442
- The new accepted-diff header has a grammar issue ("error issued" reads awkwardly) and the trailing blank line appears to contain whitespace. Consider rewording the header for clarity and drop the trailing whitespace-only line.
# Better isolatedDeclarations error issued on cast initializer before required parameter
compiler/isolatedDeclarationsAddUndefined.errors.txt.diff
jakebailey
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error corsa issues is just better, since it actually reports the issue inference failed with.