Skip to content

Commit 38e3b3c

Browse files
committed
Address PR review feedback
- Revert ci.yml change that added feature/* to PR triggers - Add documentation to SchemaOptions model and name property - Add clarifying comment for regex in type-utils.ts (addresses false-positive HTML injection warning from security bot)
1 parent 7d69aac commit 38e3b3c

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

eng/common/pipelines/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ pr:
88
include:
99
- main
1010
- release/*
11-
- feature/*
1211

1312
extends:
1413
template: /eng/common/pipelines/templates/1es-redirect.yml

packages/graphql/lib/schema.tsp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,12 @@ using TypeSpec.Reflection;
55
namespace TypeSpec.GraphQL;
66

77
namespace Schema {
8+
/** Options for configuring a GraphQL schema. */
89
model SchemaOptions {
10+
/**
11+
* The name of the GraphQL schema. Used in the output filename when emitting
12+
* multiple schemas (e.g., `{name}.graphql`). Defaults to `"schema"`.
13+
*/
914
name?: string;
1015
}
1116
}

packages/graphql/src/lib/type-utils.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ export function stripNullVariants(union: Union): {
7878
/** Generate a GraphQL type name for a templated model (e.g., `ListOfString`). */
7979
export function getTemplatedModelName(model: Model): string {
8080
const name = getTypeName(model, {});
81+
// Strip generic type parameters from compiler type names (e.g., "List<string>" → "List").
82+
// This regex matches angle-bracket syntax, not HTML — output is GraphQL SDL identifiers.
8183
const baseName = toTypeName(name.replace(/<[^>]*>/g, ""));
8284
const templateString = getTemplateString(model);
8385
return templateString ? `${baseName}Of${templateString}` : baseName;

0 commit comments

Comments
 (0)