refactor: replace file-level eslint-disable with targeted suppressions

Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>

Author: Copilot

packages/compiler/src/testing/code-fix-testing.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import { ok, strictEqual } from "assert";
 import { applyCodeFix, applyCodeFixes } from "../core/code-fixes.js";
 import { getNodeAtPosition, parse, visitChildren } from "../core/parser.js";
@@ -49,6 +48,7 @@ export function expectCodeFixOnAst(code: string, callback: (node: Node) => CodeF
     const node = getNodeAtPosition(script, pos);
     ok(node, "Expected node at cursor. Make sure to have ┆ to mark which node.");
     const codefix = callback(node);
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
     const host = await createTestHost();
     let updatedContent: string | undefined;
     await applyCodeFix(
@@ -91,6 +91,7 @@ export function expectCodeFixesOnAst(
     }
     ok(diagnostics.length > 0, "Expected node at cursor. Make sure to have ┆ to mark which node.");
     const codeFixes = callback(diagnostics);
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
     const host = await createTestHost();
     let updatedContent: string | undefined;
     await applyCodeFixes(

packages/compiler/src/testing/fs.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import { readdir, readFile, stat } from "fs/promises";
 import { join } from "path";
 import { pathToFileURL } from "url";
@@ -124,6 +123,7 @@ function createTestFileSystemInternal(
     jsImports.set(key, exports);
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-deprecated
   async function addTypeSpecLibrary(testLibrary: TypeSpecTestLibrary) {
     assertNotFrozen();
 

packages/compiler/src/testing/index.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 export {
   /** @deprecated Using this should be a noop. Prefer new test framework*/
   StandardTestLibrary,
@@ -16,6 +15,7 @@ export {
 } from "./rule-tester.js";
 export { extractCursor, extractSquiggles } from "./source-utils.js";
 export type { TestHostOptions } from "./test-compiler-host.js";
+/* eslint-disable @typescript-eslint/no-deprecated -- exporting deprecated APIs for backward compatibility */
 export { createTestHost, createTestRunner, findFilesFromPattern } from "./test-host.js";
 export {
   createTestLibrary,
@@ -26,9 +26,9 @@ export {
   trimBlankLines,
   type TestWrapperOptions,
 } from "./test-utils.js";
+/* eslint-enable @typescript-eslint/no-deprecated */
 export { createTester } from "./tester.js";
 export type {
-  BasicTestRunner,
   EmitterTester,
   EmitterTesterInstance,
   JsFile,
@@ -37,12 +37,17 @@ export type {
   TestCompileResult,
   TestEmitterCompileResult,
   TestFileSystem as TestFileSystem,
+  Tester,
+  TesterInstance,
+} from "./types.js";
+/* eslint-disable @typescript-eslint/no-deprecated -- exporting deprecated APIs for backward compatibility */
+export type {
+  BasicTestRunner,
   TestFiles,
   TestHost,
   TestHostConfig,
   TestHostError,
-  Tester,
-  TesterInstance,
   TypeSpecTestLibrary,
   TypeSpecTestLibraryInit,
 } from "./types.js";
+/* eslint-enable @typescript-eslint/no-deprecated */

packages/compiler/src/testing/rule-tester.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import { ok, strictEqual } from "assert";
 import { applyCodeFix as applyCodeFixReal } from "../core/code-fixes.js";
 import { createDiagnosticCollector } from "../core/diagnostics.js";
@@ -70,6 +69,7 @@ export interface ApplyCodeFixExpect {
 }
 
 export function createLinterRuleTester(
+  // eslint-disable-next-line @typescript-eslint/no-deprecated
   runner: BasicTestRunner | TesterInstance,
   ruleDef: LinterRuleDefinition<string, DiagnosticMessages>,
   libraryName: string,
@@ -222,6 +222,7 @@ export function createLinterRuleTester(
   }
 }
 
+// eslint-disable-next-line @typescript-eslint/no-deprecated
 function isLegacyTestRunner(tester: BasicTestRunner | TesterInstance): tester is BasicTestRunner {
   return "autoCodeOffset" in tester;
 }

packages/compiler/src/testing/test-compiler-host.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import { RmOptions } from "fs";
 import { fileURLToPath, pathToFileURL } from "url";
 import { CompilerPackageRoot, NodeHost } from "../core/node-host.js";
@@ -7,6 +6,7 @@ import { CompilerHost, StringLiteral, Type } from "../core/types.js";
 import { resolveVirtualPath } from "./fs.js";
 import { TestFileSystem, TestHostError, TypeSpecTestLibrary } from "./types.js";
 
+// eslint-disable-next-line @typescript-eslint/no-deprecated
 export const StandardTestLibrary: TypeSpecTestLibrary = {
   name: "@typespec/compiler",
   packageRoot: CompilerPackageRoot,
@@ -45,6 +45,7 @@ export function createTestCompilerHost(
     async readUrl(url: string) {
       const contents = virtualFs.get(url);
       if (contents === undefined) {
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         throw new TestHostError(`File ${url} not found.`, "ENOENT");
       }
       return createSourceFile(contents, url);
@@ -53,6 +54,7 @@ export function createTestCompilerHost(
       path = resolveVirtualPath(path);
       const contents = virtualFs.get(path);
       if (contents === undefined) {
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         throw new TestHostError(`File ${path} not found.`, "ENOENT");
       }
       return createSourceFile(contents, path);
@@ -101,6 +103,7 @@ export function createTestCompilerHost(
       path = resolveVirtualPath(path);
       const module = jsImports.get(path);
       if (module === undefined) {
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         throw new TestHostError(`Module ${path} not found`, "ERR_MODULE_NOT_FOUND");
       }
       return module;
@@ -133,6 +136,7 @@ export function createTestCompilerHost(
         }
       }
 
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       throw new TestHostError(`File ${path} not found`, "ENOENT");
     },
 

packages/compiler/src/testing/test-host.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import assert from "assert";
 import { glob } from "fs/promises";
 import { logDiagnostics, logVerboseTestOutput } from "../core/diagnostics.js";
@@ -12,6 +11,7 @@ import { addTestLib, StandardTestLibrary } from "./test-compiler-host.js";
 import { createTestWrapper, resolveVirtualPath } from "./test-utils.js";
 import { BasicTestRunner, TestHost, TestHostConfig, TypeSpecTestLibrary } from "./types.js";
 
+/* eslint-disable @typescript-eslint/no-deprecated -- implementing deprecated APIs for backward compatibility */
 /** @deprecated Use {@link createTester} */
 export async function createTestHost(config: TestHostConfig = {}): Promise<TestHost> {
   const testHost = await createTestHostInternal();
@@ -81,6 +81,7 @@ async function createTestHostInternal(): Promise<TestHost> {
     return [testTypes, p.diagnostics];
   }
 }
+/* eslint-enable @typescript-eslint/no-deprecated */
 
 export async function findFilesFromPattern(directory: string, pattern: string): Promise<string[]> {
   const results: string[] = [];

packages/compiler/src/testing/test-utils.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import { fail, ok } from "assert";
 import { fileURLToPath } from "url";
 import { getTypeName } from "../core/helpers/type-name-utils.js";
@@ -34,6 +33,7 @@ export function findTestPackageRoot(fileUrl: string): Promise<string> {
  * @returns TypeSpec Test library.
  * @deprecated Use {@link createTester} instead
  */
+// eslint-disable-next-line @typescript-eslint/no-deprecated
 export function createTestLibrary(init: TypeSpecTestLibraryInit): TypeSpecTestLibrary {
   const { name } = init;
   const typespecFileFolder = init.typespecFileFolder ?? "lib";
@@ -74,6 +74,7 @@ export interface TestWrapperOptions {
   compilerOptions?: CompilerOptions;
 }
 /** @deprecated Use {@link createTester} instead */
+/* eslint-disable @typescript-eslint/no-deprecated -- implementing deprecated API for backward compatibility */
 export function createTestWrapper(
   host: TestHost,
   testWrapperOptions: TestWrapperOptions = {},
@@ -117,6 +118,7 @@ export function createTestWrapper(
     },
   };
 }
+/* eslint-enable @typescript-eslint/no-deprecated */
 
 export function trimBlankLines(code: string) {
   let start = 0;

packages/compiler/src/testing/types.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import type { CompilerOptions } from "../core/options.js";
 import type { Program } from "../core/program.js";
 import type { CompilerHost, Diagnostic, Entity, Type } from "../core/types.js";
@@ -39,6 +38,7 @@ export interface TestFileSystem {
   addRealTypeSpecFile(path: string, realPath: string): Promise<void>;
   addRealJsFile(path: string, realPath: string): Promise<void>;
   addRealFolder(path: string, realPath: string): Promise<void>;
+  // eslint-disable-next-line @typescript-eslint/no-deprecated
   addTypeSpecLibrary(testLibrary: TypeSpecTestLibrary): Promise<void>;
 
   /** @internal */
@@ -221,6 +221,7 @@ export interface PositionedMarkerInFile extends PositionedMarker {
 // #endregion
 
 // #region Legacy Test host
+/* eslint-disable @typescript-eslint/no-deprecated -- defining deprecated APIs for backward compatibility */
 /** @deprecated Use {@link Tester} */
 export interface TestHost extends Pick<
   TestFileSystem,
@@ -317,4 +318,5 @@ export interface BasicTestRunner {
     options?: CompilerOptions,
   ): Promise<[Record<string, Type>, readonly Diagnostic[]]>;
 }
+/* eslint-enable @typescript-eslint/no-deprecated */
 // #endregion

packages/events/src/testing/index.ts

@@ -1,8 +1,9 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import { createTestLibrary, findTestPackageRoot } from "@typespec/compiler/testing";
 
 /** @deprecated Use `createTester` from `@typespec/compiler/testing` instead */
+/* eslint-disable @typescript-eslint/no-deprecated */
 export const EventsTestLibrary = createTestLibrary({
   name: "@typespec/events",
   packageRoot: await findTestPackageRoot(import.meta.url),
 });
+/* eslint-enable @typescript-eslint/no-deprecated */

packages/html-program-viewer/src/testing/index.ts

@@ -1,13 +1,14 @@
-/* eslint-disable @typescript-eslint/no-deprecated */
 import {
   createTestLibrary,
   findTestPackageRoot,
   type TypeSpecTestLibrary,
 } from "@typespec/compiler/testing";
 
 /** @deprecated Use `createTester` from `@typespec/compiler/testing` instead */
+/* eslint-disable @typescript-eslint/no-deprecated */
 export const ProgramViewerTestLibrary: TypeSpecTestLibrary = createTestLibrary({
   name: "@typespec/html-program-viewer",
   jsFileFolder: "dist/emitter",
   packageRoot: await findTestPackageRoot(import.meta.url),
 });
+/* eslint-enable @typescript-eslint/no-deprecated */