Conversation
msyyc
requested review from
JoshLove-msft,
iscai-msft,
srnagar and
timotheeguerin
as code owners
Contributor
|
No changes needing a change description found. |
Contributor
Author
|
@timotheeguerin / @iscai-msft pls help review |
timotheeguerin
approved these changes
Apr 30, 2026
msyyc
requested review from
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
…t/typespec into emitter-ci-drop-node-20
weidongxu-microsoft
approved these changes
May 7, 2026
JoshLove-msft
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node 20 is end-of-life
Changes
20.x→24.x(secondary remains22.x). Node 20 is no longer used.eng/emitters/pipelines/templates/stages/emitter-stages.ymlvia newPrimaryNodeVersion/SecondaryNodeVersionparameters, replacing all hardcodedNodeVersionliterals across build and test stages.
DetectApiChangesstageDependsOnderive the build job name dynamically:Build_linux_${{ split(parameters.PrimaryNodeVersion, '.')[0] }}. Fixes the CI errorjob DetectApiChanges depends on unknown job Build_linux_20and ensures the dependency tracks future Node bumps automatically.PrimaryNodeVersionthroughpackages/http-client-csharp/eng/pipeline/publish.ymlso thestageDependencies.CSharp_Build.Build_linux_<major>reference is also derived from the same parameter —no further edits required on the next Node upgrade.
eng/emitters/pipelines/templates/steps/test-step.ymlfrom20.x→22.xfor consistency.