[libremidi] update to 5.2.0

[Mengna-Li]

Fixes #44612.

No feature needs to test.
Usage tested pass on x64-windows.

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[jcelerier]

If you want I can tag 5.1.1 with the fix

[Mengna-Li]

If you want I can tag 5.1.1 with the fix

That would be great~

[dg0yt]

Why is this patch needed? Doesn't windowsapp already come fromt the (uwp) toolchain?

[Mengna-Li]

Why is this patch needed? Doesn't windowsapp already come fromt the (uwp) toolchain?

I encountered the above error when installing on x64 windows.

[dg0yt]

Why is this patch needed? Doesn't windowsapp already come fromt the (uwp) toolchain?

I encountered the above error when installing on x64 windows.

Did you consider disabling the UWP backend on non-uwp?

[dg0yt]

• IMO the port should set LIBREMIDI_NO_WINUWP on non-uwp. This would have fixed the original problem with non-uwp windows triplets. Upstream's win32: add windowsapp which seems needed on MSVC celtera/libremidi#149 should probably be reverted.
• Upstream has some new vendored downloads. These must be prevented in the port. Disabled, replaced either dependencies or with explicit downloads in the portfile. Asset caching!

[Mengna-Li]

• Upstream has some new vendored downloads. These must be prevented in the port. Disabled, replaced either dependencies or with explicit downloads in the portfile. Asset caching!

I'm not quite sure, which vendor downloads are you referring to?

[jcelerier]

note that without this download vpckg has to provide cppwinrt

[jcelerier]

also @dg0yt "UWP" works fine in non-UWP Win32 apps, it's just the name of the API (https://learn.microsoft.com/en-us/windows/uwp/audio-video-camera/midi)

[jcelerier]

@Mengna-Li the download is this I assume: -

• https://github.com/celtera/libremidi/blob/master/cmake/libremidi.winmidi.cmake#L5
• https://github.com/celtera/libremidi/blob/8e5874786e49c655a31c17b61b5a94e6681de26d/cmake/libremidi.cppwinrt.cmake#L54

[dg0yt]

note that without this download vpckg has to provide cppwinrt

Note that vcpkg has a port cppwinrt.

[totalgee]

So this is blocked...? The issue seems to be regarding how/where cppwinrt is obtained (whether downloaded by the project's CMake or installed as a vcpkg package)? Or is it because "the UWP backend should be disabled on on non-uwp"? Who gets final say on this: the library author or someone from vcpkg team? One way or another, it would be nice to have this latest version of libremidi available via vcpkg...

[dg0yt]

The key blocker are the vendored downloads. vcpkg manages dependencies, not every port by itself.
Often it is not difficult to do the download in the portfile.
Using dependencies from vcpkg ports is usually a strong requirement. This can be tricky with tight version constraints.
But until today we don't even see it being tried.

[jcelerier]

@dg0yt I'm definitely willing to look for cppwinrt from outside, but I'm not sure how to change my cmakelists to make sure everything is in order.

• If I'm building on a MinGW / MSYS2 compiler I want to find MSYS2's cppwinrt
• If I'm building on a "traditional" visual studio command-line tools shell I want to find cppwinrt.exe in the windows sdk set to CMake
• I guess if I'm using vcpkg I want to find vcpkg's cppwinrt - will find_program(cppwinrt just find it in that case? will it work on both MinGW (which requires a patched version of cppwinrt) and MSVC?

for instance I want to avoid the case where someone builds in a mingw environment with vcpkg, and things fail mysteriously because vcpkg's cppwinrt package does not work with msys2's clang64

[jcelerier]

@totalgee I'd be willing to add a testcase building with vcpkg on the CI, would you happen to have a couple lines of examples I could put in a GH action ?

[dg0yt]

find_program(VAR ...) is a customization point. Users can just set the right value, or they can adjust the search path. And so the libremidi port can simply pass the known location via OPTIONS.

This wouldn't cover mingw triplets, but the task would be to adapt the cppwinrt port. If it can't install cppwinrt for mingw, it could still provide information for downstream ports.

[totalgee]

@totalgee I'd be willing to add a testcase building with vcpkg on the CI, would you happen to have a couple lines of examples I could put in a GH action ?

You mean an example of using vcpkg to build a project with libremidi? Sure, I'll open an issue on your repo with some example code.

[BillyONeal]

@dg0yt convinced me about new vendored dependencies..

[jcelerier]

fyi @Mengna-Li for 5.3 which will be released soon, I added a CMake var to control whether the cppwinrt and winmidi nupkgs are downloaded as part of the build or not