[babl] Update to 0.1.126, add native msvc support#50922
Conversation
talregev
force-pushed
the
TalR/babl/msvc
branch
7 times, most recently
from
606ba5b to
c72a6a0
Compare
|
I patch upstream: |
talregev
force-pushed
the
TalR/babl/msvc
branch
4 times, most recently
from
67556d9 to
9d23657
Compare
|
Upstream approve and merge my patch 🥳 |
|
Yeah, more mallocs for free! |
I know you can do it better! |
|
@vicroms |
|
These are too many product code patches, now that they have been merged upstream, perhaps we should wait for an upstream release with them included. |
vicroms
added
the
requires:vcpkg-team-review
|
@brunvonlope FYI |
@talregev I can't tag a commit on babl/gegl repos because I'm not the maintainer. I will ask to the maintainer anyway since we are close to release gimp 3.2.4 but no promises 😅 |
The same also for gegl 🙈 |
|
Done: https://gitlab.gnome.org/GNOME/gimp/-/issues/16193#note_2728943 From my experience observing babl/gegl releases, I suggest to not hold your breath and merge this as it is for now, them the patches can be removed when the new versions came out |
It not depend on me. The official vcpkg respond for this PR (babl) is wait for babl release. |
Thank you! |
talregev
force-pushed
the
TalR/babl/msvc
branch
from
9d23657 to
d18c490
Compare
talregev
force-pushed
the
TalR/babl/msvc
branch
from
d18c490 to
3b3139c
Compare
talregev
force-pushed
the
TalR/babl/msvc
branch
from
3b3139c to
7350699
Compare
talregev
force-pushed
the
TalR/babl/msvc
branch
from
7350699 to
a10fd0f
Compare
|
@vicroms I update to next version of babl that include the msvc support. |
talregev
changed the title
BillyONeal
removed
the
requires:vcpkg-team-review
|
This was "requires:vcpkg-team-review" due to number / size of patches, which no longer applies. |
|
|
||
| /* If the DLL file name is of the format | ||
| - * <foobar>\bin\*.dll, use <foobar>\lib\{BABL_LIBRARY}. | ||
| + * <foobar>\bin\*.dll, use <foobar>\plugins\{BABL_LIBRARY}. |
There was a problem hiding this comment.
- I'm a bit nervous that this won't get correctly picked up by
applocal.ps1et al. since these are not going to be static dependencies. What happens to an end user's program if these plugins aren't present? Is this a change that comes from this update specifically or are you just trying to fix something that has always been toast? - I'm a bit nervous that this accidentally makes every DLL in here not get checked by post build lint.
babl:x64-windows:/bin/babl-0.1-0.dll
babl:x64-windows:/bin/babl-0.1-0.pdb
babl:x64-windows:/debug/bin/babl-0.1-0.dll
babl:x64-windows:/debug/bin/babl-0.1-0.pdb
babl:x64-windows:/debug/lib/babl-0.1.lib
babl:x64-windows:/debug/lib/pkgconfig/babl-0.1.pc
babl:x64-windows:/debug/plugins/babl-0.1/avx2-int8.dll
babl:x64-windows:/debug/plugins/babl-0.1/avx2-int8.lib
babl:x64-windows:/debug/plugins/babl-0.1/avx2-int8.pdb
Should it be bin/plugins ?
There was a problem hiding this comment.
@BillyONeal This is not a specific issue for babl but has been an unresolved topic for years: applocal.ps1 is uninformed about plugins (except for hacks for qt and magnum). All we got is the recommendation of using plugins/<group>.
There was a problem hiding this comment.
In gazebo we put the plugins in plugins folder. The same pattern here.
Let me know your decision
There was a problem hiding this comment.
@BillyONeal This is not a specific issue for babl but has been an unresolved topic for years: applocal.ps1 is uninformed about plugins (except for hacks for qt and magnum). All we got is the recommendation of using
plugins/<group>.
I understand that it's a general problem but it's a problem that as far as I understand it didn't apply to this port before?
There was a problem hiding this comment.
This port didn't compile on windows before. If I don't mistake, there was a share libs on lib folder on linux, but your scripts doesn't detect it.
BillyONeal
added
the
requires:vcpkg-team-review
|
(And now I'm adding requires:vcpkg-team-review again due to the "plugins" question) |
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks and sorry for the delay while Bill confirmed 😅
|
(To be clear, applocal.ps1 remains a big problem but as you mentioned before, this problem was already here, we just didn't detect it on Linux before) |
5 participants
./vcpkg x-add-version --alland committing the result.