Skip to content

[iso-codes] Add new port#50955

Merged
vicroms merged 1 commit into
microsoft:masterfrom
brunvonlope:bruno/iso-codes
Apr 6, 2026
Merged

[iso-codes] Add new port#50955
vicroms merged 1 commit into
microsoft:masterfrom
brunvonlope:bruno/iso-codes

Conversation

@brunvonlope
Copy link
Copy Markdown
Contributor

@brunvonlope brunvonlope commented Apr 4, 2026

This is needed for localization support on GIMP

  • Changes comply with the maintainer guide.
  • The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
    • The project is in Repology: https://repology.org/iso-codes/versions
    • The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
    • The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
  • Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@brunvonlope brunvonlope force-pushed the bruno/iso-codes branch 2 times, most recently from d20ffc3 to b9e536d Compare April 4, 2026 00:47
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After committing all changes, run vcpkg x-add-version --overwrite-version iso-codes to update the files in versions/. This will fix the x86-windows check.

Comment thread ports/iso-codes/portfile.cmake Outdated
Comment thread ports/iso-codes/portfile.cmake Outdated
Comment thread ports/iso-codes/portfile.cmake Outdated
Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @dg0yt

@brunvonlope please implement dg0yt's suggestions

@vicroms vicroms marked this pull request as draft April 4, 2026 05:38
@brunvonlope brunvonlope force-pushed the bruno/iso-codes branch 3 times, most recently from f17a90c to be9753b Compare April 5, 2026 20:39
@brunvonlope brunvonlope marked this pull request as ready for review April 5, 2026 20:53
@brunvonlope brunvonlope requested review from dg0yt and vicroms April 5, 2026 21:00
This is needed for localization support on GIMP.
@vicroms vicroms merged commit 48ee41e into microsoft:master Apr 6, 2026
16 checks passed
gnomesysadmins pushed a commit to GNOME/gimp that referenced this pull request Apr 7, 2026
@brunvonlope brunvonlope deleted the bruno/iso-codes branch April 7, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants