[dawn] Enable tint spirv generation support when building dawn with vulkan#50977
Merged
Conversation
tstraus
changed the title
dg0yt
reviewed
Apr 6, 2026
| set(DAWN_USE_BUILT_DXC ON) | ||
| endif() | ||
| set(DAWN_USE_TINT_SPV OFF) | ||
| if(DAWN_ENABLE_VULKAN) |
Contributor
There was a problem hiding this comment.
Does this only depend on vulkan, or is it also coupled to tint or other dependencies?
Suggested change
| if(DAWN_ENABLE_VULKAN) | |
| if(DAWN_ENABLE_VULKAN AND "tint" IN_LIST FEATURES) |
(I don't know. I just see the name of the tint feature.)
Contributor
Author
There was a problem hiding this comment.
Tint the library is always built, the feature for command line tools for tint.
Contributor
There was a problem hiding this comment.
@tstraus is right.
Maybe we should rename tint feature to tint-tools?
Contributor
Author
There was a problem hiding this comment.
I would be for that. It honestly threw me for a bit while trying to figure out what was going on with this.
Contributor
There was a problem hiding this comment.
Instead of tint-tools, it might also be simply tools. IDK.
Anyways, it looks like a topic for another PR.
vicroms
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using dawn with a vulkan backend, it fails to compile wgsl shaders as it's compiled with a tint that does not have the spirv generation feature enabled.
This PR enables that spirv generation feature when the vulkan feature of dawn is enabled.