Skip to content

[libde265] update to 1.0.19#51875

Closed
toge wants to merge 1 commit into
microsoft:masterfrom
toge:libde265-1.0.19
Closed

[libde265] update to 1.0.19#51875
toge wants to merge 1 commit into
microsoft:masterfrom
toge:libde265-1.0.19

Conversation

@toge
Copy link
Copy Markdown
Contributor

@toge toge commented May 20, 2026

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

https://github.com/strukturag/libde265/releases/tag/v1.0.19

@vicroms
Copy link
Copy Markdown
Member

vicroms commented May 21, 2026

Drafting because of CI issues. AI review:


The version bump itself is conventional and the checksum/version database changes are coherent. Removing fix-arm-neon-clang.patch may be correct if upstream 1.0.19 incorporated an equivalent fix; Android ARM and ARM64 no longer fail while building libde265 itself in the observed CI logs.

The higher-risk change is the rebased pkgconfig-cxx-linkage.diff. The previous patch replaced hard-coded -lstdc++/-lc++ with an initially empty LIBS_PRIVATE built from implicit C++ link libraries. The new upstream has its own _libs_private list and pthread handling; the vcpkg patch appends C++ implicit libraries as strings, while the upstream block still emits -lpthread when pthreads are detected. On Android, the static pkg-config consumer link line contains both -pthread and -lpthread, and ld.lld cannot resolve -lpthread:

FAILED: [code=1] main-pkconfig
... libheif.a  ... libde265.a  -lpthread  ... libx265.a  -lc++ ... -latomic -lm && :
ld.lld: error: unable to find library -lpthread
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

This is tightly coupled to the libde265 .pc metadata because the failing test is a pkg-config based static consumer of libheif/libde265 on Android. The patch should avoid emitting -lpthread on Android, use an Android-appropriate flag, or otherwise keep Libs.private compatible with NDK linking.

@vicroms vicroms marked this pull request as draft May 21, 2026 09:21
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented May 21, 2026

I can't decrypt the AI review but I believe that for the pkgconfig file, the old patch is better than the new upstream.

@toge toge closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants