You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The version bump itself is conventional and the checksum/version database changes are coherent. Removing fix-arm-neon-clang.patch may be correct if upstream 1.0.19 incorporated an equivalent fix; Android ARM and ARM64 no longer fail while building libde265 itself in the observed CI logs.
The higher-risk change is the rebased pkgconfig-cxx-linkage.diff. The previous patch replaced hard-coded -lstdc++/-lc++ with an initially empty LIBS_PRIVATE built from implicit C++ link libraries. The new upstream has its own _libs_private list and pthread handling; the vcpkg patch appends C++ implicit libraries as strings, while the upstream block still emits -lpthread when pthreads are detected. On Android, the static pkg-config consumer link line contains both -pthread and -lpthread, and ld.lld cannot resolve -lpthread:
This is tightly coupled to the libde265 .pc metadata because the failing test is a pkg-config based static consumer of libheif/libde265 on Android. The patch should avoid emitting -lpthread on Android, use an Android-appropriate flag, or otherwise keep Libs.private compatible with NDK linking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.https://github.com/strukturag/libde265/releases/tag/v1.0.19