[dbus] fix embedded system bus socket path on Unix#51908
Open
miyanyan wants to merge 5 commits into
Open
Conversation
vicroms
requested changes
May 23, 2026
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Contributor
Author
|
the ci error seems not related with this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled-in default
DBUS_SYSTEM_BUS_DEFAULT_ADDRESSwas embeddinga vcpkg-package-relative path like:
unix:path=<vcpkg_root>/packages/dbus_<triplet>/var/run/dbus/system_bus_socketThis is because dbus CMake derives
RUNSTATEDIRfrom GNUInstallDirs,which defaults relative to
CMAKE_INSTALL_PREFIX. On vcpkg the prefixpoints to the package directory, not the system root.
Fix by explicitly passing
-DRUNSTATEDIR=/runon all Unix platforms,consistent with how Linux distros package dbus (e.g. Debian passes
--with-system-socket=/run/dbus/system_bus_socket).Fixes #51890.