Skip to content

[tesults-cpp] Add tesults-cpp v1.0.1#51918

Draft
ajeetd wants to merge 4 commits into
microsoft:masterfrom
ajeetd:add-tesults-cpp-1.0.0
Draft

[tesults-cpp] Add tesults-cpp v1.0.1#51918
ajeetd wants to merge 4 commits into
microsoft:masterfrom
ajeetd:add-tesults-cpp-1.0.0

Conversation

@ajeetd
Copy link
Copy Markdown

@ajeetd ajeetd commented May 22, 2026

Summary

This PR adds the tesults-cpp port — a C++ library for uploading test results to Tesults.

Port details

Field Value
Name tesults-cpp
Version 1.0.0
Dependencies curl, nlohmann-json, openssl

Testing

Port was tested locally on macOS (Apple Silicon) with:

  • CMake 3.14+
  • AppleClang 21
  • vcpkg install tesults-cpp

The example in the upstream repo builds and links correctly against the installed library.

Checklist

  • Port files follow vcpkg conventions
  • vcpkg x-add-version run and versioning files committed
  • SHA512 verified against GitHub archive
  • vcpkg_install_copyright included
  • file(REMOVE_RECURSE ...) removes debug/include duplicates

Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add host-only dependencies on vcpkg-cmake and vcpkg-cmake-config to use the helper functions in portfile.cmake.

Comment on lines +7 to +11
"dependencies": [
"curl",
"nlohmann-json",
"openssl"
]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dependencies": [
"curl",
"nlohmann-json",
"openssl"
]
"dependencies": [
"curl",
"nlohmann-json",
"openssl",
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
]

@vicroms vicroms marked this pull request as draft May 23, 2026 07:41
@ajeetd ajeetd requested a review from vicroms May 24, 2026 00:12
@ajeetd ajeetd marked this pull request as ready for review May 24, 2026 15:48
@vicroms vicroms changed the title Add tesults-cpp v1.0.0 [tesults-cpp] Add tesults-cpp v1.0.1 May 26, 2026
)

vcpkg_cmake_install()
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tesults)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot found issues with the integration files. There's a missing find_dependency(nlohmann_json).

Installed CMake package is not consumable as generated. find_package(tesults CONFIG REQUIRED) fails because tesultsTargets.cmake references nlohmann_json::nlohmann_json, while tesultsConfig.cmake does not find nlohmann-json. Fix upstream or patch the port so the installed config calls find_dependency(nlohmann_json CONFIG REQUIRED) before including tesultsTargets.cmake.

Comment on lines +7 to +12
},
{
"git-tree": "eedba78f36ff095ef39a29ae1e55af924ec5bb21",
"version": "1.0.0",
"port-version": 0
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
{
"git-tree": "eedba78f36ff095ef39a29ae1e55af924ec5bb21",
"version": "1.0.0",
"port-version": 0
}
}

Only one version of a port per PR.

@vicroms vicroms marked this pull request as draft May 26, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants