Skip to content

Optimize WebSocket receive path on pre-netstandard2.1 targets #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AArnott merged 3 commits into from
Jun 23, 2026
Merged

Optimize WebSocket receive path on pre-netstandard2.1 targets #1462

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
993f996
Initial plan
Copilot Jun 12, 2026
81263b6
Optimize netfx websocket read buffer path
Copilot Jun 12, 2026
3b4a2f9
Limit pooled receive segment to destination memory length
Copilot Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/StreamJsonRpc/WebSocketMessageHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,27 @@ void IJsonRpcMessageBufferManager.DeserializationComplete(JsonRpcMessage message
result = await this.WebSocket.ReceiveAsync(memory, cancellationToken).ConfigureAwait(false);
this.contentSequenceBuilder.Advance(result.Count);
#else
ArrayPool<byte> pool = ArrayPool<byte>.Shared;
byte[] segment = pool.Rent(this.sizeHint);
try
Memory<byte> memory = this.contentSequenceBuilder.GetMemory(this.sizeHint);
if (MemoryMarshal.TryGetArray(memory, out ArraySegment<byte> segment))
{
result = await this.WebSocket.ReceiveAsync(new ArraySegment<byte>(segment), cancellationToken).ConfigureAwait(false);
this.contentSequenceBuilder.Write(segment.AsSpan(0, result.Count));
result = await this.WebSocket.ReceiveAsync(segment, cancellationToken).ConfigureAwait(false);
}
finally
else
{
pool.Return(segment);
ArrayPool<byte> pool = ArrayPool<byte>.Shared;
byte[] rented = pool.Rent(memory.Length);
try
{
result = await this.WebSocket.ReceiveAsync(new ArraySegment<byte>(rented, 0, memory.Length), cancellationToken).ConfigureAwait(false);
rented.AsSpan(0, result.Count).CopyTo(memory.Span);
}
finally
{
pool.Return(rented);
}
}

this.contentSequenceBuilder.Advance(result.Count);
#endif
if (result.MessageType == WebSocketMessageType.Close)
{
Expand Down
Loading