Merge latest Library.Template updates#1479
Merged
Merged
Conversation
There is sometimes an issue with the clone/create PR step. When that happens, the stage isn't requeuable because the VSTS upload step fails when its run again because the payload is already there. This update allows the step to clone the VS repo and create the PR to be rerun due to issues independent of the Upload step.
Also remove a task that was duplicated (I think) unnecessarily.
Split the VS PR stage separately from the upload steps
Use explicit UTF-8 appends for GitHub Actions environment files so Linux runners don't hit an invalid empty-name env entry after build. This updates both the general env propagation helper and the pipeline variable definition script. Co-authored-by: 🤖 Copilot <no-reply@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Improve and share github actions env var setting function
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Update Microsoft Testing Platform to 2.3.0
Adopt the incoming Library.Template package updates in Directory.Packages.props while keeping the repo-specific MessagePack version property. Also tighten the GC helper used by collection-sensitive tests with additional finalizer waits so the updated test platform remains stable without weakening the assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR merges the latest Library.Template updates into vs-streamjsonrpc, aligning build pipelines and GitHub workflows with the shared template while keeping a repo-specific DocFX validation step and improving GC-sensitive test stability.
Changes:
- Update CI/1ES Azure Pipelines definitions (network isolation settings, Ubuntu 24.04 pools, and insertion job structure).
- Update GitHub workflows (checkout pin updates) and tooling/test package versions (MTP + related extensions).
- Add a GitHub Actions env-writing helper and adjust scripts/tests for more stable execution.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/variables/_define.ps1 | Switches GitHub Actions env propagation to a helper function. |
| tools/Set-EnvVars.ps1 | Uses GitHub Actions env helper for variable propagation; minor formatting changes. |
| tools/GitHubActions.ps1 | Adds helper to write to GITHUB_ENV using the multi-line safe format. |
| test/StreamJsonRpc.Tests/TestBase.cs | Adds extra GC/finalizer waits for more stable collection assertions. |
| Directory.Packages.props | Updates MTP-related versions; adds telemetry extension; updates NBGV; adjusts PolySharp reference. |
| azure-pipelines/vs-validation.yml | Updates pipeline settings, pools, and splits upload/insertion jobs. |
| azure-pipelines/vs-insertion.yml | Updates pipeline settings and splits upload vs insertion steps. |
| azure-pipelines/unofficial.yml | Updates network isolation settings and Ubuntu pool image. |
| azure-pipelines/release.yml | Updates network isolation settings and Ubuntu pool image. |
| azure-pipelines/prepare-insertion-stages.yml | Updates Ubuntu pool image for publish jobs. |
| azure-pipelines/official.yml | Updates network isolation settings and Ubuntu pool image. |
| azure-pipelines/libtemplate-update.yml | Updates network isolation settings and Ubuntu pool image. |
| azure-pipelines/archive-sourcecode.yml | Updates network isolation settings and Ubuntu pool image. |
| .github/workflows/libtemplate-update.yml | Updates pinned actions/checkout version. |
| .github/workflows/docs.yml | Updates pinned actions/checkout version. |
| .github/workflows/docs_validate.yml | Updates pinned actions/checkout version and keeps Ubuntu 24.04 runner. |
| .github/workflows/copilot-setup-steps.yml | Updates pinned actions/checkout version. |
| .github/skills/bundle-dependency-prs/SKILL.md | Adds guidance for rerunning checks; includes a minor wording update. |
| .config/dotnet-tools.json | Updates tool versions (PowerShell and NBGV). |
olegtk
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings
vs-streamjsonrpcforward to the latestLibrary.Templatemicrobuild changes so the repo stays aligned with the shared build and workflow conventions.The merge keeps the incoming template updates across the pipeline and GitHub workflow files, while resolving the repo-specific DocFX validation conflict by preserving the source-generator build step and the
vs-threadinglink-checker exception. It also adopts the template's newer testing and tooling package versions inDirectory.Packages.props, while keeping the repo-specificMessagePackVersionproperty.A small follow-up test helper change adds extra finalizer waits in the GC-sensitive assertion path so the updated Microsoft.Testing.Platform package set remains stable without weakening the underlying assertions.
All restore, build, and
tools/dotnet-test-cloud.ps1 -Configuration Releasevalidation passed.