Merge latest Library.Template#1480
Merged
Merged
Conversation
Use preferred pattern for appending to PATH in GitHub Actions
There was a problem hiding this comment.
Pull request overview
Updates repo tooling to align with the latest Library.Template GitHub Actions environment conventions, particularly around when to load GitHub Actions helpers and how to propagate PATH changes in CI.
Changes:
- Only dot-source
tools/GitHubActions.ps1fromtools/variables/_define.ps1when running under GitHub Actions. - Switch GitHub Actions PATH propagation in
tools/Set-EnvVars.ps1from writingPATHto$GITHUB_ENVto appending entries to$GITHUB_PATH. - Add validation and a dedicated helper (
Add-GitHubActionsPath) for writing to GitHub Actions’ path file.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/variables/_define.ps1 | Loads GitHub Actions helper functions only when $env:GITHUB_ACTIONS is set. |
| tools/Set-EnvVars.ps1 | Uses $GITHUB_PATH (via Add-GitHubActionsPath) to propagate PATH prepends in GitHub Actions. |
| tools/GitHubActions.ps1 | Adds input validation for $GITHUB_ENV and introduces Add-GitHubActionsPath for $GITHUB_PATH. |
| .github/skills/bundle-dependency-prs/SKILL.md | Minor doc formatting/spelling adjustment in the skill instructions. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… (537) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…emplate Specifically, this merges [3749d32 from that repo](AArnott/Library.Template@3749d32).
dabbbf2 to
003d56a
Compare
This reverts commit b5153f6. The dependency isn't allowed per CFS policy yet.
…emplate Specifically, this merges [e6e3c19 from that repo](AArnott/Library.Template@e6e3c19).
…emplate Specifically, this merges [65a9b52 from that repo](AArnott/Library.Template@65a9b52).
…emplate Specifically, this merges [bd12df8 from that repo](AArnott/Library.Template@bd12df8).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
tools/Set-EnvVars.ps1:92
- Using GITHUB_PATH preserves the order that entries are written, but this script’s prepend loop builds PATH by prepending sequentially (and previously wrote PATH via GITHUB_ENV), which results in the final PATH order being reversed for multiple PrependPath entries. This change will alter PATH precedence across steps in GitHub Actions when more than one path is prepended. To preserve the existing behavior, write GITHUB_PATH entries in reverse order (or compute and set PATH once).
if ($PrependPath) {
$PrependPath | % {
$newPathValue = "$_$pathDelimiter$env:PATH"
Set-Item -LiteralPath env:PATH -Value $newPathValue
if ($cmdInstructions) {
Write-Host "SET PATH=$newPathValue"
}
if ($env:TF_BUILD) {
Write-Host "##vso[task.prependpath]$_"
}
if ($env:GITHUB_ACTIONS) {
Add-GitHubActionsPath -Value $_
}
$CmdEnvScript += "SET PATH=$_$pathDelimiter%PATH%"
}
}
…_ThrowsTimeoutException` test
SylviaLe191
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.