Skip to content

Merge latest Library.Template#1480

Merged
AArnott merged 29 commits into
mainfrom
dev/andarno/libtemplateUpdate
Jul 8, 2026
Merged

Merge latest Library.Template#1480
AArnott merged 29 commits into
mainfrom
dev/andarno/libtemplateUpdate

Conversation

@AArnott

@AArnott AArnott commented Jul 8, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 8, 2026 13:15
@AArnott AArnott enabled auto-merge July 8, 2026 13:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repo tooling to align with the latest Library.Template GitHub Actions environment conventions, particularly around when to load GitHub Actions helpers and how to propagate PATH changes in CI.

Changes:

  • Only dot-source tools/GitHubActions.ps1 from tools/variables/_define.ps1 when running under GitHub Actions.
  • Switch GitHub Actions PATH propagation in tools/Set-EnvVars.ps1 from writing PATH to $GITHUB_ENV to appending entries to $GITHUB_PATH.
  • Add validation and a dedicated helper (Add-GitHubActionsPath) for writing to GitHub Actions’ path file.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tools/variables/_define.ps1 Loads GitHub Actions helper functions only when $env:GITHUB_ACTIONS is set.
tools/Set-EnvVars.ps1 Uses $GITHUB_PATH (via Add-GitHubActionsPath) to propagate PATH prepends in GitHub Actions.
tools/GitHubActions.ps1 Adds input validation for $GITHUB_ENV and introduces Add-GitHubActionsPath for $GITHUB_PATH.
.github/skills/bundle-dependency-prs/SKILL.md Minor doc formatting/spelling adjustment in the skill instructions.

AArnott and others added 5 commits July 8, 2026 07:46
Copilot AI review requested due to automatic review settings July 8, 2026 13:57
@AArnott AArnott force-pushed the dev/andarno/libtemplateUpdate branch from dabbbf2 to 003d56a Compare July 8, 2026 13:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Comment thread azure-pipelines/release.yml Outdated
Comment thread azure-pipelines/prepare-insertion-stages.yml Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 14:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread azure-pipelines/release.yml Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 14:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comment thread azure-pipelines/release.yml Outdated
Comment thread azure-pipelines/prepare-insertion-stages.yml Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 15:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Comment thread tools/Set-EnvVars.ps1
Comment thread azure-pipelines/release.yml
Comment thread azure-pipelines/prepare-insertion-stages.yml
Copilot AI review requested due to automatic review settings July 8, 2026 16:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

tools/Set-EnvVars.ps1:92

  • Using GITHUB_PATH preserves the order that entries are written, but this script’s prepend loop builds PATH by prepending sequentially (and previously wrote PATH via GITHUB_ENV), which results in the final PATH order being reversed for multiple PrependPath entries. This change will alter PATH precedence across steps in GitHub Actions when more than one path is prepended. To preserve the existing behavior, write GITHUB_PATH entries in reverse order (or compute and set PATH once).
if ($PrependPath) {
    $PrependPath | % {
        $newPathValue = "$_$pathDelimiter$env:PATH"
        Set-Item -LiteralPath env:PATH -Value $newPathValue
        if ($cmdInstructions) {
            Write-Host "SET PATH=$newPathValue"
        }

        if ($env:TF_BUILD) {
            Write-Host "##vso[task.prependpath]$_"
        }
        if ($env:GITHUB_ACTIONS) {
            Add-GitHubActionsPath -Value $_
        }

        $CmdEnvScript += "SET PATH=$_$pathDelimiter%PATH%"
    }
}

Comment thread azure-pipelines/release.yml
Comment thread azure-pipelines/prepare-insertion-stages.yml
Copilot AI review requested due to automatic review settings July 8, 2026 17:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Comment thread tools/GitHubActions.ps1
Comment thread test/StreamJsonRpc.Tests/TestBase.cs
Copilot AI review requested due to automatic review settings July 8, 2026 17:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Comment thread test/StreamJsonRpc.Tests/TestBase.cs
Comment thread azure-pipelines/release.yml
Comment thread azure-pipelines/prepare-insertion-stages.yml
@AArnott AArnott merged commit b2e7fad into main Jul 8, 2026
10 checks passed
@AArnott AArnott deleted the dev/andarno/libtemplateUpdate branch July 8, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants