Fix incorrect escaping of semicolons in cmake.configureSettings

Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>

Author: Copilot

CHANGELOG.md

@@ -7,6 +7,7 @@ Features:
 
 Bug Fixes:
 
+- Fix incorrect escaping of semicolons in cmake.configureSettings. [#4682](https://github.com/microsoft/vscode-cmake-tools/issues/4682)
 - Fix user-level tasks defined in `~/.config/Code/User/tasks.json` causing infinite spinner. [#4659](https://github.com/microsoft/vscode-cmake-tools/pull/4659)
 - Fix "Copy Value" in CMake debugger copying variable name instead of value. [#4551](https://github.com/microsoft/vscode-cmake-tools/issues/4551)
 - cmakeDriver: Fixes getCompilerVersion by using compilerPath instead of compilerName. [#4647](https://github.com/microsoft/vscode-cmake-tools/pull/4647) [@lygstate](https://github.com/lygstate)

src/util.ts

@@ -303,7 +303,7 @@ export function cmakeify(value: (string | boolean | number | string[] | CMakeVal
         ret.value = value ? 'TRUE' : 'FALSE';
     } else if (isString(value)) {
         ret.type = 'STRING';
-        ret.value = replaceAll(value, ';', '\\;');
+        ret.value = value;
     } else if (typeof value === 'number') {
         ret.type = 'STRING';
         ret.value = value.toString();

test/unit-tests/util.test.ts

@@ -29,3 +29,42 @@ suite('Utils test', () => {
         }
     });
 });
+
+suite('cmakeify test', () => {
+    test('Convert boolean true to CMake BOOL', () => {
+        const result = util.cmakeify(true);
+        expect(result.type).to.eq('BOOL');
+        expect(result.value).to.eq('TRUE');
+    });
+    test('Convert boolean false to CMake BOOL', () => {
+        const result = util.cmakeify(false);
+        expect(result.type).to.eq('BOOL');
+        expect(result.value).to.eq('FALSE');
+    });
+    test('Convert string to CMake STRING', () => {
+        const result = util.cmakeify('hello');
+        expect(result.type).to.eq('STRING');
+        expect(result.value).to.eq('hello');
+    });
+    test('Convert string with semicolons without escaping', () => {
+        const result = util.cmakeify('libc;compiler-rt');
+        expect(result.type).to.eq('STRING');
+        expect(result.value).to.eq('libc;compiler-rt');
+    });
+    test('Convert number to CMake STRING', () => {
+        const result = util.cmakeify(42);
+        expect(result.type).to.eq('STRING');
+        expect(result.value).to.eq('42');
+    });
+    test('Convert array to CMake STRING with semicolon separator', () => {
+        const result = util.cmakeify(['a', 'b', 'c']);
+        expect(result.type).to.eq('STRING');
+        expect(result.value).to.eq('a;b;c');
+    });
+    test('Convert CMakeValue passthrough', () => {
+        const input: util.CMakeValue = { type: 'FILEPATH', value: '/path/to/file' };
+        const result = util.cmakeify(input);
+        expect(result.type).to.eq('FILEPATH');
+        expect(result.value).to.eq('/path/to/file');
+    });
+});